TYPO3 Core

t3lib/class.t3lib_stdgraphic.php
line 2181 (in version 4.2.6 that is)

adapt line to
$params .= ' -crop '.$data['origW'].'x'.$data['origH'].'+'.$offsetX.'+'.$offsetY.'! ';

I just added the "!" at the end and it now works - "!" after the crop command tells imagemagick to adjust canvas and viewport.

Didn't test this with any other installations than the one I'm working on right now (4.2.6 with IM 6.3.7), so somebody should probably do this before this fix is commited into core.

Cheers

I can confirm this.

The fix added here
http://bugs.typo3.org/view.php?id=8025
breaks the correct cropping of GIF-Images in some cases.

Re-adding the ! after the crop command like described above, fixed the problem for me too.

Typo3: 4.2.3
PHP: 5.2.8
ImageMagick: 6.4.4

Hmm, this has been submitted over a year ago, I wonder if it's ever going to get fixed ...

That unfortunately doesn't fix it for me using ImageMagick 6.0.7

Felix,

basically your suggestion is a reverse to 8025, do I see this right? Can we narrow the issue down when this happens / or not?

This will have to be specialcased for imagemagick version, because the behaviour of im6 is the opposite of im4. Graphicsmagick crops correctly with both syntaxes.

Meaning for im6 we need the ! after -crop dimensions and for 4.2.9 it needs to be ommited.

I did the following tests:

ImageMagick 6.3.7 08/09/09 Q16:
convert -geometry 53x80! -colors 64 -crop 53x53+0+13 old.gif new.gif
Result: 53x80
convert -geometry 53x80! -colors 64 -crop 53x53+0+13! old.gif new.gif
Result: 53x53

ImageMagick 4.2.9 99/09/01:
convert -geometry 53x80! -colors 64 -crop 53x53+0+13 old.gif new.gif
Result: 53x53
convert -geometry 53x80! -colors 64 -crop 53x53+0+13! old.gif new.gif
Result: 53x80

GraphicsMagick 1.1.11 2008-02-23 Q8:
convert -geometry 53x80! -colors 64 -crop 53x53+0+13 old.gif new.gif
Result: 53x53
convert -geometry 53x80! -colors 64 -crop 53x53+0+13! old.gif new.gif
Result: 53x53

The attached patch bug_8878_fix_v1.patch against 4.3.3 should fix the issue for both im6 and im4 by making the behaviour dependant on the im version.

(im4 uses #18566 behaviour, while im6/gm uses pre #18566 behaviour)

Little reminder, please review Benjamin.

I'm currently using this patch on 4.2.12, 4.3.3 and 4.4.0 installations without problems.

Hi Felix,

the normal workflow is that who wrote a patch send it as an RFC to Core List.
There it will get attentnion (other than here).
Check what you should do: http://typo3.org/teams/core/core-mailinglist-rules

Simple testcase:

temp.img = IMAGE
temp.img {
file = fileadmin/test/img300x200.gif
file.width = 147c
file.height = 147c
wrap = <div style="background:#aaa;float:left">|</div><div style="clear:both" />
}

page = PAGE
page {
5 < temp.img
}

I'll attach img300x200.gif, which is a squared gray box on a 300x200 transparent background.

Attached testcase visualization "bug_8878_fix_testcase", please rename to .png, sorrry.

Attached clean patch against svn rev 8197.

Submitted for review.

This problem seems to be still existent in T3 4.5.19

A GIF picture original of 150px wide by 80px high cropscaled to 80px by 80px results in the 'image' being cropped, but the file has a transparent padding of 35px left and 35px right, resulting in an image of, you guessed it, 150px wide and 80px high.

I've tested using im6 and gm. Both have the same result.

Hi Matthias,

similar to Stefan, I'd like to invite you to try to submit a patch for this bug. As it seems, someone has attempted to create a patch already, however it is old and might need to be updated.

If you need further help, let me know.

- michael

@Matthias: Try the updated patch on 4.5.19. I haven't tested it due to lack of time, but it should work.

Hi Felix, please make a patch with git and push it to gerrit.

@Simon: done: http://review.typo3.org/13996

@Felix I will try to test it this week. Thanks for the quick reply! :)

Obviously I will report back when i've tested the patch.

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/14132

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13996

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13996

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13996

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13996

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23872

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23873

While the GM situation is unchanged (and seems buggy in any case), the IM6 situation seems to be fixed. I have no IM5 "at hand" but trust that it works like mentioned. From the IM documentation:

From ImageMagick version 6.2.4-5, you can add a new special flag to the "-crop" argument. This flag '!' will tell crop to adjust the canvas/page information of the returned image so that it is relative to the area cropped.

NICE! Adding features in a minor-patchlevel release. :)

BTW huge explanation on the -crop usage here: http://www.imagemagick.org/Usage/crop/

I can confirm the IM patch works with TYPO3 6.1.5 and IM Version 6.8.7-0

I applied this patch to 4.7.18 by changing ./t3lib/class.t3lib_stdgraphic.php line 2228 and it fixes the .gif-crop-problem there, too.
Any chance of getting this applied to the 4.7-branch upstream?

Greets,
Jonas