TYPO3 Core

for easy testing i uploaded the complete extension

Nothing found after login...

Without being logged in, indexed_search works perfectly. After the login, no searchresults...

Installed Versions.
typo3 4.2.6
sr_feuser_register 2.5.19
fe_login 1.0
indexed_search 2.11.999 (got it from Steffen Kampers http://bugs.typo3.org/view.php?id=9574)
macina_searchbox 2.2.0

I also tried it with the crawler-Extension, added the necessary ID's - But it didn't work.

Anyone got an idea?

While having this big patch with new configurations, would it be possible to add http://bugs.typo3.org/view.php?id=11706 which brings TS prefs for those:

summaryMax=300
postPreLgd=60
postPreLgd_offset=6
divider= ... 

V5 is in Corelist but there was performance improvements by Ruppi after this one...

unfortunally there was no review until feature freeze, so this patch has only chance for 4.4. Sad ...

While I appreciate the much greater flexibility which would be introduced by this patch, I'd think that it might be a good idea to add some "backwards compatibility care pack" to avoid breaking indexed_search after updating within installations that use their "own" templateFile. This own templateFile wouldn't contain the new subparts and therefore indexed_search would output nothing at all after an update (subpart ###SEARCH_RESULTS### missing).

As far as I can see, the following subparts would require a fallback:
###SEARCH_FORM_HIDDEN###, ###BROWSE_BOX_TOP###, ###BROWSE_BOX_BOTTOM###, ###SEARCH_RESULTS###, ###SEARCH_NO_RESULTS###

How about putting these subparts into separate fallback template files shipped with indexed_search, then within the pi-class, check for existance of these subparts (in the TS .templateFile given template) and if not found there, load them from the fallback? 5 additional ifs should do no (more) harm to indexed_search regarding the performance.

Added _v7 (based on latest patch _v6 from core list, for TYPO3 4.3 only).

There are some more configuration options, the default settings are set so that nothing is different from the current version of indexed_search (but of course more configurable)

new TS configuration:

• TS options to configure what is shown within the resultlist (thus related to #20421) [plugin.tx_indexedsearch.show.results.]
  resultList = [boolean, default 1]
  resultBrowserTop = [boolean, default 1]
  resultBrowserBottom = [boolean, default 1]

• TS option to disable link in section titles (related to #16794) [plugin.tx_indexedsearch.]
  linkSectionTitles = [boolean, default 1]

• TS option to wrap result list (related to #16386) [plugin.tx_indexedsearch.]
  listcontent_stdWrap [->stdWrap, default: listcontent_stdWrap.wrap = |]

• integrated #14902, since it is partially solved anyways here. Corresponding new TS options [plugin.tx_indexedsearch.pageBrowser.]
  makePointerLinksWithHref = [boolean, default 0] @Steffen: please test, if this is still compatible to your version, since #14902 supposes to add search settings as get params, which is now included
  makePointerLinksWithHref.ATagParams = class="tx-indexedsearch-pointerLink"
  makePointerLinksWithForm = 0
  makePointerLinksWithForm.submit_params = class="tx-indexedsearch-pointerButton"

• solved #20875, new TS options [plugin.tx_indexedsearch.results.]
  summaryCropAfter = [int, default 50]
  summaryCropSignifier = [string, default emtpy]
  titleCropAfter = [int, default 180]
  titleCropSignifier = [string default '...']
  markupSW_summaryMax = [int, default 300]
  markupSW_postPreLgd = [int, default 60]
  markupSW_postPreLgd_offset = [int, default 5]
  markupSW_divider = [string, default empty]

• TS option to enable no_cache when forwarding search words in result links [plugin.tx_indexedsearch.]
  forwardSearchWordsInResultLink_no_cache = [boolean, default 1]

Furthermore:

• Additional HTML marker ###CSSCLASS_EVEN_ODD### for alternating result rows

• Additional variable stored to register: $GLOBALS['TSFE']->register['indexed_search_RESULTCOUNT'] (may be used for TS wrappings using data = register:indexed_search_RESULTCOUNT)

Finally, there has been done some slight clean up compared to _v6 from core list.

Solves http://bugs.typo3.org/view.php?id=4444

This huge patch has top be split into many smaller patches. Remember: a single issue per patch is allowed by commit rules!

Hm. Then this one might be treated as sort of a collective storyboard for improving the templating of indexed_search...

Dmitry, are you into solving/reviewing some of the issues collected here? Let me know, we could easily split up the collection that we have here into smaller chunks.

Only that Steffen's initial templating patch is sort of huge for itself... and I wouldn't want to split this one up - that's been the reason why I hooked in here - probably I shouldn't have.

Great enhancement - thanks! Would like to see it implemented soon.