Project

General

Profile

Actions

Feature #21565

closed

Generating multiple directories for images in GB/ and pics/

Added by Ries van Twisk about 15 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Start date:
2009-11-16
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

When TYPO3 needs to generate many thousands of images (>50.000) then most file systems will slow down because TYPO3 will put all generated images into one directory.

- All files are store stored under the GB and pics directory, and sub-directories are created based on there
filename's data.

- There are 4 additional settings added to config_default.php to set the levels and filename's length for gifbuilder and imagemagick.

- The functions fileName and createTempSubDir are backwards compatible and behave the same.

However the function fileName now as an option to not add a tempDir to a generated filename. This was done to prevent funky str_replaces for path creations in the gifBuild function

The function createTempSubDir now uses mkdir_deep from t3lib_div to create 'deep' (recursive) sub directories

I believe that the patch might not be CGL compatible, I hope to hear your comments on that. If you have any other suggestions/comments/questions. Please let me know.

Ries

Example:

When the number of levels to create is set to 3, and the size of the filename is set to 16.

Then if the generate image name is: fa361bcd532ea5f4.jpg

The following directory will get create: typo3temp/f/a/3/fa361bcd532ea5f4.jpg

(issue imported from #M12609)


Files

12609.patch (9.25 KB) 12609.patch Administrator Admin, 2009-11-16 13:19
12609_v2.patch (8.4 KB) 12609_v2.patch Administrator Admin, 2009-11-27 22:58
Actions #1

Updated by Ries van Twisk about 15 years ago

gifbuilder.patch was a faulty upload (how can I delete it??, or how can I upload multiple files at the same time?)

12609.patch contains the file patch.

Ries

Actions #2

Updated by Xavier Perseguers about 15 years ago

Someone with proper rights should move this entry to Core bugtracker. thanks.

Actions #3

Updated by Xavier Perseguers about 15 years ago

Ries, gifbuilder.patch has been removed

Actions #4

Updated by Bernhard Kraft almost 15 years ago

Your patch didn't work completly. You missed to replace the mkdir by the mkdir_deep of t3lib_div

I fixed this. Also there was a typo for config default. For the "im_" properties you wrote is about the "GB/" directory, and for the "gb_" properties you wrote about the "pics/" directory.

Actions #5

Updated by Alexander Opitz almost 11 years ago

  • Target version deleted (0)
  • TYPO3 Version set to 4.4

Hi,

as this issue is very old. Is this feature missing in newer versions of TYPO3 CMS (6.1)?
If yes, can you provide a newer patch against master by using Gerrit? http://wiki.typo3.org/CWT

Actions #6

Updated by Alexander Opitz almost 11 years ago

  • Status changed from New to Needs Feedback
Actions #7

Updated by Alexander Opitz over 10 years ago

  • Category set to File Abstraction Layer (FAL)
  • Status changed from Needs Feedback to New

I rethought this issue and it isn't solved and would be a good enhancement.

Actions #8

Updated by Mathias Schreiber almost 9 years ago

  • Status changed from New to Closed
  • Target version set to Candidate for Major Version

those

Actions #9

Updated by Mathias Schreiber almost 9 years ago

  • Status changed from Closed to New

sorry, Redmine and keyboard navigation aren't the best friends.
We will keep this issue open of course :)

Actions #10

Updated by Sybille Peters over 6 years ago

Thank you for your report.

Even though it has been some time, would you consider submitting a new patch to our Gerrit review server?

Someone could do this for you, but I am thinking you might like the opportunity to contribute to TYPO3 yourself.

You can find a description of the TYPO3 contribution workflow here: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/

Hint: If you get stuck anywhere, ask on Slack in the #typo3-cms-coredev channel. You can register in the TYPO3 slack workspace here: https://forger.typo3.com/slack

Also, if your issue is no longer reproducable, please let us know in the slack channel, so that this issue can be closed.

Thank you in advance!

Sybille

Actions #11

Updated by Benni Mack about 6 years ago

  • Status changed from New to Needs Feedback

Hey,

we've improved in TYPO3 v9 in this area:
- uploads/pics/ is no longer in use - uploads/ is completely removed actually if not needed
- FAL processed files does "nested subfolders" for generated images
- for menus ("GB/") this is not the case, however we decided to remove GMENU in TYPO3 v10.0, as this concept is not "recommended" anymore.

So, we've improved, we could do the "GB/" folder (which is now typo3temp/assets/menu/) but could you give me a use-case (TypoScript setup) where this folder is populated now with more than e.g. 100 files?

Actions #12

Updated by Susanne Moog over 5 years ago

  • Status changed from Needs Feedback to Closed

No feedback in the last five months, closing the issue now. If the request is still valid please open a new ticket or discuss with us on Slack.

Actions

Also available in: Atom PDF