TYPO3 Core

F*ck.. ExtJS driven messages have already been added in 4.4 :(

I suggest to remove the target version.

Steffen Gebert wrote:

I suggest to remove the target version.

I suggest to remove ExtJs Flash Messages (maybe adding a ;), but maybe not)... Seriously, where are they used where we couldn't use the real deal?
Example: The new EM uses ExtJs Flash Messages, but they really should do a reload and use static ones for the actions where they are used...

They are needed for ExtJS modules, as they don't reload.

Some more details on this:

The core constantly uses the constants name instead of numbers when calling TYPO3.Flashmessage.display(). One exception: t3lib/js/extjs/components/pagetree/javascript/actions.js - This bug should be fixed.

I could not find a dedicated documentation for usage of ExtJS based Flashmessages, but one for t3lib_FlashMessage . This doc advices one to use constants, not numbers.

We now have in ExtJS based FlashMessage

TYPO3.Severity = {
    notice: 0,
    information: 1,
    ok: 2,
    warning: 3,
    error: 4
};

This is not in sync with t3lib_message_AbstractMessage

const NOTICE  = -2;
const INFO    = -1;
const OK      = 0;
const WARNING = 1;
const ERROR   = 2;

Both patterns do not look very logical to me, since I am used to order of RFC 3164, which suggest the following pattern. This one is already implemented in the core logging API in incubator

const EMERGENCY = 0;
const ALERT = 1;
const CRITICAL = 2;
const ERROR = 3;
const WARNING = 4;
const NOTICE = 5;
const INFO = 6;
const DEBUG = 7;

Ok is not part of this pattern. I am not sure how this should be handled.

What do you think?

I would name the constants like this:

Ext.Flashmessage.Level

In PHP we do already have logging constants:

LOG_EMERG (integer)
LOG_ALERT (integer)
LOG_CRIT (integer)
LOG_ERR (integer)
LOG_WARNING (integer)
LOG_NOTICE (integer)
LOG_INFO (integer)
LOG_DEBUG (integer)
LOG_KERN (integer)

Why not using these constants?

Regards
Kay

Kay, would you like to join the logging project team meeting and discuss this issue? Tomorrow, Wed., 2011/12/20 17:30 CET at http://bigbluebutton.typo3.org

Steffen Müller wrote:

Kay, would you like to join the logging project team meeting and discuss this issue? Tomorrow, Wed., 2011/12/20 17:30 CET at http://bigbluebutton.typo3.org

Do we need to discuss these constants again?

Kay Strobach wrote:

In PHP we do already have logging constants:
...
Why not using these constants?

there were (are) a couple of reasons why we didn't use them

• use of abbreviations
• they are for some reason located in networking which creates a somewhat strange feeling
• the integer values are identical, so you could use them anyway if you wanted to
• a little more control for us

In the end these are of course just minor things but still...
Does that answer your question?

best
Ingo

This issue is solved with #62893 (https://review.typo3.org/#/c/34029/).
I will close this issue.