Bug #24256

All TCA forms "group" with size=1 have height of 85px

Added by Stefan Froemken over 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-12-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Normally with a TCA config like this:

'type' => 'group',
'internal_type' => 'db',
'allowed' => 'pages',
'size' => '1',
'maxitems' => '1',
'minitems' => '0',
'show_thumbs' => '1',

you got a input field with roundabout 20-25px height.

But now: All group-fields with size = 1 has a height of 85px. This is because of a new CSS in TYPO3:

.typo3-TCEforms select.tceforms-multiselect {
min-height:85px;
}

CSS-Class for Multiselect should not be activated, when size=1

TYPO3 4.5-dev Rev. 9705
(issue imported from #M16628)


Files

tceforms_multiselect.patch (1.67 KB) tceforms_multiselect.patch Administrator Admin, 2011-01-16 23:06

Related issues

Related to TYPO3 Core - Feature #23827: Change the layout of thumbnails and allowed file types so that they don't waste so much space anymoreClosedErnesto Baschny2010-10-22

Actions
Related to TYPO3 Core - Bug #25221: "group" field in TCEforms does not honor size=1 attributeClosedDmitry Dulepov2011-03-02

Actions
#1

Updated by Stefan Froemken over 10 years ago

When it was committed to trunk rev. 9391 why it is still there in Rev. 9705?

#2

Updated by Georg Ringer over 10 years ago

nobody said this has been fixed with rev 9391 ...

#3

Updated by Benni Mack over 10 years ago

Well, the HTML code should be changed that the size=1 doesn't get the option "multiselect" but only the ones that say "multiple=true" - right?

#4

Updated by Steffen Gebert over 10 years ago

Yes, I think so.

#5

Updated by Jo Hasenau over 10 years ago

exactly - as discussed on Skype I just didn't expect the class "multiselect" to be assigned to single selectboxes as well.

#6

Updated by Benni Mack over 10 years ago

One thing though that came to my mind, Joey: if I select "size=2" and multiple=true - then we still have a min-height of 85px which I don't find pretty cool. So, I'm actually in favor of removing the 85px again.

#7

Updated by Jo Hasenau over 10 years ago

I think these are two different issues.

The class should be mutliselect only for multiple selectboxes anyway.
The min-height can then still be removed but at least it will be possible to style single and multiple selectboxes differently.

#8

Updated by Steffen Gebert over 10 years ago

Anybody working on this?

#9

Updated by Benni Mack over 10 years ago

Hey Steffen.

I attached a patch which fixes both issues (renaming the class depending on the size, and the min-height of 85px which shouldn't be there anyway).

Could you send it to the core list?

Thanks.
Benni.

#10

Updated by Ernesto Baschny over 10 years ago

Ready to commit, according to the core list, Steffen :)

#11

Updated by Steffen Gebert over 10 years ago

Being of for 3 hours and the RM gets nervous :D

Will commit next hour ;-)

#12

Updated by Steffen Gebert over 10 years ago

rev. 10103

#13

Updated by Susanne Moog about 10 years ago

  • Target version deleted (4.5.0)

Also available in: Atom PDF