Bug #24256
closed
All TCA forms "group" with size=1 have height of 85px
0%
Description
Normally with a TCA config like this:
'type' => 'group',
'internal_type' => 'db',
'allowed' => 'pages',
'size' => '1',
'maxitems' => '1',
'minitems' => '0',
'show_thumbs' => '1',
you got a input field with roundabout 20-25px height.
But now: All group-fields with size = 1 has a height of 85px. This is because of a new CSS in TYPO3:
.typo3-TCEforms select.tceforms-multiselect {
min-height:85px;
}
CSS-Class for Multiselect should not be activated, when size=1
TYPO3 4.5-dev Rev. 9705
(issue imported from #M16628)
Files
Updated by Stefan Froemken over 13 years ago
When it was committed to trunk rev. 9391 why it is still there in Rev. 9705?
Updated by Georg Ringer over 13 years ago
nobody said this has been fixed with rev 9391 ...
Updated by Benni Mack over 13 years ago
Well, the HTML code should be changed that the size=1 doesn't get the option "multiselect" but only the ones that say "multiple=true" - right?
Updated by Jo Hasenau over 13 years ago
exactly - as discussed on Skype I just didn't expect the class "multiselect" to be assigned to single selectboxes as well.
Updated by Benni Mack over 13 years ago
One thing though that came to my mind, Joey: if I select "size=2" and multiple=true - then we still have a min-height of 85px which I don't find pretty cool. So, I'm actually in favor of removing the 85px again.
Updated by Jo Hasenau over 13 years ago
I think these are two different issues.
The class should be mutliselect only for multiple selectboxes anyway.
The min-height can then still be removed but at least it will be possible to style single and multiple selectboxes differently.
Updated by Benni Mack over 13 years ago
Hey Steffen.
I attached a patch which fixes both issues (renaming the class depending on the size, and the min-height of 85px which shouldn't be there anyway).
Could you send it to the core list?
Thanks.
Benni.
Updated by Ernesto Baschny over 13 years ago
Ready to commit, according to the core list, Steffen :)
Updated by Steffen Gebert over 13 years ago
Being of for 3 hours and the RM gets nervous :D
Will commit next hour ;-)
Updated by