Bug #24342

t3lib_lock still sometimes has a race condition on deleting locks.

Added by Björn Pedersen almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-12-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The problem of already deleted lock files still exists. * Solution : Add a "static" lock class and implement a lockFile-Lock.

Another problem was, that locks that never were acquired were never released properly:
The early return in release returned wrongly
  • add a destruct member and use it as second flag for the early return

The patch probably still needs some cleanup, e.g. where to keep the lockLock instance.
(issue imported from #M16749)


Files

t3lib_class.t3lib_lock.php.patch (12.1 KB) t3lib_class.t3lib_lock.php.patch Administrator Admin, 2010-12-15 13:15
16749_v2.patch (21.5 KB) 16749_v2.patch Administrator Admin, 2010-12-16 14:18
16749-v3.diff (30.4 KB) 16749-v3.diff Administrator Admin, 2010-12-20 10:34
16749-v3a.diff (30.4 KB) 16749-v3a.diff Administrator Admin, 2010-12-20 10:58

Related issues

Related to TYPO3 Core - Feature #18557: Integrate locking by database in t3lib_lockRejectedBenni Mack2008-04-03

Actions
Has duplicate TYPO3 Core - Bug #32282: typo3temp/locks warning. unlink function returns warningClosed2011-12-03

Actions

Also available in: Atom PDF