TYPO3 Core

It took some time to went though t3lib/class.t3lib_tceforms.php but i found the problem that appears in users, groups and file_mounts.

With revision 9966 there was a change in config_default.php and tbl_be.php:
http://forge.typo3.org/projects/typo3v4-core/repository/revisions/9966/

The problem here is to remove such lines within these elements:
'renderMode' => $GLOBALS['TYPO3_CONF_VARS']['BE']['accessListRenderMode']

The "renderMode" config doesn't appear in TCA anymore. But it's necessary within class.t3lib_tceforms.php to avoid an empty-empty image and this funny url.

-> I added a patch just to shows the old lines, BUT it would bring back a checkbox!

Sascha ;-)

This would always end in "empty-empty":

if ($iField && $iPath && $row[$iField]) {
$iParts = t3lib_div::trimExplode(',', $row[$iField], 1);
$icon = '../' . $iPath . '/' . trim($iParts⁰);
} elseif (t3lib_div::inList('singlebox,checkbox', $fieldValue['config']['renderMode'])) {
$icon = t3lib_iconWorks::mapRecordTypeToSpriteIconName($f_table, $row);
} else {
$icon = 'empty-empty';
}

Thanks for investigating!

I think renderMode => 'singlebox' would restore the old value. However I don't think that fixes the problem itself (it just would not occur in this place anymore ;)).

Without digging deeper into it, empty-empty has to be replaced with path to clear.gif (or sth. better).

What do you think about the patch? I didn't delete anything, its just catches empty-empty.

I've just pointed SteffenR to this issue, who is probably responsible for this feature ^^.

I don't know, what this code should do in detail and under what circumstances the first option returning a path in icon is chosen. They're somehow contrary to each other.

Hello Sascha,
thanks for your contribution.
Anyways your patch "fixes" the wrong place.

Even the code you quoted, where empy empty is set is correct.

As you see, the function getIcon is called with an SpriteIcon name. This never should happen. getIcon is the "old" function.
Therefore the call itself would have to be fixed. Have a look at the attached patch...

Hey Steffen,
iam new to the core files. These patches are my first stepp into this world. Hope that this helps instead of confusing other developers. I check your patch and found two missing brackets at the end of "if(is_file....". By the way, nice solution :-).

Of course, you help and your contributions are welcome!

missing brackets at the end of "if(is_file....".

ah right :)
hacked this locally ... if it works for you - we/I can go to core list ...

@Sascha: is this working for you as you expectext

It removes the style from such "options" (empty-empty). For me this patch works fine :-)

thanks Sascha, I put it to the core list

Patch set 1 of change Ie5db6d6a6b6b7ccdd5772a829be0ca236787cd9a has been pushed to the review server.
It is available at http://review.typo3.org/5394

Patch set 2 of change Ie5db6d6a6b6b7ccdd5772a829be0ca236787cd9a has been pushed to the review server.
It is available at http://review.typo3.org/5394