Bug #25213: Install Tool allows editing settings added by extensions duplicating them on the way - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (3)

Clemens Riccabona
Patrick Rodacker
Simon Schaufelberger

Actions

Copy link

Bug #25213

closed

Install Tool allows editing settings added by extensions duplicating them on the way

Added by Tobias Schaefer about 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Ernesto Baschny

Category:

Install Tool

Target version:

Start date:

2011-03-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.4

PHP Version:

5.2

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

When I save 'Install Tool' / 'All Configuration', I get (while not having changed anything!):
$TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] = '[GLOBAL]\' . LF . \'extension.pdf_generator2.typeNum = 123';

This was already fixed with the patch of bug #21501 and TYPO3 4.4.1. but somehow the bug still occurs in TYPO3 4.4.7.

1) I have installed "pdf_generator2" that does
t3lib_extMgm::addTypoScriptConstants('extension.pdf_generator2.typeNum = 123");
in ext_localconf.php
2) Every save in 'Install Tool' / 'All Configuration' duplicates the contents of $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants']
(issue imported from #M17813)

Related issues 4 (0 open — 4 closed)

Related to TYPO3 Core - Bug #21501: Install Tool duplicates values of textarea fields

Closed

Steffen Kamper

2009-11-09

Actions

Related to TYPO3 Core - Bug #23929: Install tool: defaultTypoScript_setup should be textarea

Closed

Steffen Gebert

2010-11-03

Actions

Related to TYPO3 Core - Bug #24129: Installer - All Configuration - [default TS setup] is a input field instead of a teaxtarea

Rejected

2010-11-18

Actions

Precedes TYPO3 Core - Bug #35410: PHP warning: Unknown modifier 'r' in tx_install

Closed

Jigal van Hemert

2012-03-30

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Clemens Riccabona about 13 years ago

same here on a 4.5.0, 4.5.1 and 4.5.2 and a 4.4.5

and i can NOT confirm this have ever been fixed in a official TYPO3 release (but i did not try every service release since this anoying problem occurred).

Actions

Copy link

Updated by Tobias Schaefer about 13 years ago

i've looked at the affected files from patch 12514_v3.diff and it seems that the code changes applied by this patch is in the core of 4.4.7. So, I assume that patch 12514 doesn't really do what it is supposed to do.

Actions

Copy link

Updated by Simon Schaufelberger about 12 years ago

Target version deleted (0)

Hi,
This issue is still valid for 4.5.10 and is so annoying.

Actions

Copy link

Updated by Clemens Riccabona about 12 years ago

Yes Please, it is really much anoying!

Actions

Copy link

Updated by Ernesto Baschny about 12 years ago

Subject changed from Install Tool duplicates values of textarea fields to Install Tool allows editing settings added by extensions duplicating them on the way
Category set to Install Tool
Status changed from New to Accepted
Assignee set to Ernesto Baschny
Complexity set to medium

The problem is not of duplicating "multi-line fields" (as it was before, and fixed in the mentioned issue #21501).

In this case the problem is that the Install Tool is allowing to edit settings which are added by Extensions (through e.g. t3lib_extMgm::addTypoScriptSetup). These additions are appended to existing settings. So each time you edit and save these again, more and more lines will be generated.

Solution is to track the settings which are added by extensions (through the API) and don't allow to edit this specific snippets.

Actions

Copy link