Bug #25213
closed
Install Tool allows editing settings added by extensions duplicating them on the way
Added by Tobias Schaefer over 13 years ago.
Updated about 6 years ago.
Description
When I save 'Install Tool' / 'All Configuration', I get (while not having changed anything!):
$TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] = '[GLOBAL]\' . LF . \'extension.pdf_generator2.typeNum = 123';
This was already fixed with the patch of bug #21501 and TYPO3 4.4.1. but somehow the bug still occurs in TYPO3 4.4.7.
1) I have installed "pdf_generator2" that does
t3lib_extMgm::addTypoScriptConstants('extension.pdf_generator2.typeNum = 123");
in ext_localconf.php
2) Every save in 'Install Tool' / 'All Configuration' duplicates the contents of $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants']
(issue imported from #M17813)
same here on a 4.5.0, 4.5.1 and 4.5.2 and a 4.4.5
and i can NOT confirm this have ever been fixed in a official TYPO3 release (but i did not try every service release since this anoying problem occurred).
i've looked at the affected files from patch 12514_v3.diff and it seems that the code changes applied by this patch is in the core of 4.4.7. So, I assume that patch 12514 doesn't really do what it is supposed to do.
- Target version deleted (
0)
Hi,
This issue is still valid for 4.5.10 and is so annoying.
Yes Please, it is really much anoying!
- Subject changed from Install Tool duplicates values of textarea fields to Install Tool allows editing settings added by extensions duplicating them on the way
- Category set to Install Tool
- Status changed from New to Accepted
- Assignee set to Ernesto Baschny
- Complexity set to medium
The problem is not of duplicating "multi-line fields" (as it was before, and fixed in the mentioned issue #21501).
In this case the problem is that the Install Tool is allowing to edit settings which are added by Extensions (through e.g. t3lib_extMgm::addTypoScriptSetup). These additions are appended to existing settings. So each time you edit and save these again, more and more lines will be generated.
Solution is to track the settings which are added by extensions (through the API) and don't allow to edit this specific snippets.
- Status changed from Accepted to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
I am happy to see this in a most likley coming 4.5.12 release - finally! :-)
Thanks a lot, Ernesto!
Thank you from me as well!
This change causes a PHP Warning. As I don't understand the code, it would be nice, if the authors could have a look at #35410.
- Status changed from Resolved to Under Review
- Status changed from Under Review to Resolved
- Status changed from Resolved to Under Review
- Status changed from Under Review to Resolved
Accidently reopened by Gerrit script
- Status changed from Resolved to Closed
Also available in: Atom
PDF