Bug #29352

t3lib_extMgm::addToAllTCAtypes broken

Added by Robert Wildling almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2011-08-30
Due date:
% Done:

0%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

As confirmed by Jo Hasenau, t3lib_extMgm::addToAllTCAtypes cannot be used with an empty 3rd parameter:

t3lib_extMgm::addToAllTCAtypes("tt_content", 'subheader;;8', '', 'after:header');

As with Typo3 4.5 this causes the creation of a new tab "extended", whereas the "subheader" field should show up right underneath the header field.

At the moment only a construction like the following works:

t3lib_extMgm::addToAllTCAtypes("tt_content", 'subheader;;8', 'text,textpic', 'after:header');

t3lib_div_extMgm.diff View (3.55 KB) Jo Hasenau, 2011-08-30 19:48

History

#1 Updated by Robert Wildling almost 8 years ago

  • Project changed from TYPO3 Core to v4 Usability Team
  • Category deleted (Backend User Interface)
  • Target version deleted (4.5.6)

Moved from TYPO3 v4 Core

#2 Updated by Jo Hasenau almost 8 years ago

  • Project changed from v4 Usability Team to TYPO3 Core

#3 Updated by Jo Hasenau almost 8 years ago

  • Target version set to 4.5.6

#4 Updated by Jo Hasenau almost 8 years ago

As mentioned in the description I can confirm this behaviour. Currently I am investigating why this happens, and why nobody complained so far.
After all 4.5.x is out for quite a while now.

#5 Updated by Jo Hasenau almost 8 years ago

It seems that this fix http://forge.typo3.org/issues/25187 introduced at least one reason for the misbehaviour.

Although I have been able to fix it, still there are some other problems regarding strings containing more than the field name.

t3lib_extMgm::addToAllTCAtypes("tt_content", 'subheader', '', 'after:header');

works with the fixed version, while
t3lib_extMgm::addToAllTCAtypes("tt_content", 'subheader;;8', '', 'after:header');

does not.

#6 Updated by Jo Hasenau almost 8 years ago

Please test attached patch.

Should be working with both variants and even with more than one field at once.

#7 Updated by Andreas Wolf almost 8 years ago

  • Category set to Backend API
  • Complexity set to easy

#9 Updated by Tolleiv Nietsch almost 8 years ago

the patch looks good for me - any reason why this shouldn't be in Gerrit?

#10 Updated by Chris topher almost 8 years ago

  • Target version changed from 4.5.6 to 4.5.8

#11 Updated by Mr. Jenkins over 7 years ago

  • Status changed from New to Under Review

Patch set 1 of change I187c0ce388de7b878b2adf42d133a0758971f42c has been pushed to the review server.
It is available at http://review.typo3.org/7005

#12 Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7005

#13 Updated by Ernesto Baschny over 7 years ago

  • Target version changed from 4.5.8 to 4.5.12

#14 Updated by Robert Wildling over 7 years ago

Any progress here? The targeted version 4.5.12 obviousely hasn't been updated with this patch, neither has been 4.5.14.

Thanks for the info!

#15 Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7005

#16 Updated by Steffen Ritter over 6 years ago

  • Status changed from Under Review to Needs Feedback
  • Priority changed from Must have to Could have

No action for 1.5 years - the pushed patchset has been abandond

#17 Updated by Alexander Opitz almost 6 years ago

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

#18 Updated by Markus Klein over 5 years ago

  • Status changed from Needs Feedback to Closed
  • Is Regression set to No

No feedback within the last 90 days => closing this ticket.

If you experience this issue again, please open a new ticket and add a relation to this ticket number.

Also available in: Atom PDF