Bug #32625
closed
Custom RTE-styles broken
100%
Description
Fix for #29899 broke custom HTML-styles.
Check for
file_exists(PATH_site . $fileName)
results in paths like:
/var/www/html/../fileadmin/rte.css
(which is one ../ too deep)
That path is because of the fact it was created to be used for /typo3/alt_doc.php to find it's CSS with relative URLs.
This is broken in the latest release of 4.5.9, 4.6.2 and master.
How to test:- Create a fileadmin/rte.css
- Add page-TS: RTE.default.contentCSS = fileadmin/rte.css
- Try editing content in RTE -> falls back to default.css
Updated by Stefan Neufeind almost 13 years ago
We'd need to replace
file_exists(PATH_site . $fileName)
with
file_exists(PATH_site . 'typo3/' . $fileName)
BUT that won't work for links starting with "../" since a path of
/var/www/html/typo3/../fileadmin/rte.css
won't resolve correctly if typo3 is a symlink. (Manually removing "typo3/../" works though of course.)
Hmm ...
Updated by Gerrit Code Review almost 13 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7314
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7314
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7314
Updated by Gerrit Code Review almost 13 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7314
Updated by Gerrit Code Review almost 13 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7314
Updated by Stanislas Rolland almost 13 years ago
- Assignee set to Stanislas Rolland
- Target version set to 4.5.10
- PHP Version set to 5.3
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7340
Updated by Stanislas Rolland almost 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 30 to 100
Applied in changeset 9c5409b435751f6d5769e63add70eb0abfb37e8e.
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7341
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7342
Updated by Stanislas Rolland almost 13 years ago
- Status changed from Under Review to Resolved
Applied in changeset b7caf1d0d8f6d7744e296d2c67c87500c0841054.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed