Project

General

Profile

Actions

Bug #33592

closed

Moved translated content elements are in wrong colpos

Added by Georg Ringer almost 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Imagine 2 pages, both with a page_language_overlay and a contentelement with a language overlay.

If a content element in sys_language=0 is moved to the 2nd page, the page module shows both new content elements in sys_language = 0. If the one content element which has been moved and is a translation, is opend, then english is selected as language (so this is correct).

IMO there are 2 possible places where this can be fixed:
- Adopt the page module, imo the place is in tx_cms_layout.php
- or better idea: a moved placeholder should not loose its colPos


Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #33594: Missing argument 4 for t3lib_TCEmain::moveL10nOverlayRecords(), called in ...version\class.tx_version_tcemain.php on line 1376 Closed2012-02-01

Actions
Actions #1

Updated by Georg Ringer almost 13 years ago

oh sorry, its about the sys_language_uid

the record with info "MOVE-TO PLACEHOLDER for #5610" should also have the sys_language_uid of the original and not 0

Actions #2

Updated by Stefan Neufeind almost 13 years ago

Could it be this is related to #32967 which aims to fix an issue with colPos on publish? For that there is a patch in gerrit already. Please have a look.

Actions #3

Updated by Georg Ringer almost 13 years ago

no sorry it is about the sys_language_uid.

how to test:
  1. Go to live workspace and create 2 pages, on both a content element
  2. (Still in live) translate pages + content elements
  3. Switch to draft ws
  4. cut one one content element and paste it after the another one at the other page
  5. you will see that the translated content element got moved too (which is correct) but the translated content element is shown in default language!
Actions #4

Updated by Gerrit Code Review almost 13 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8997

Actions #5

Updated by Gerrit Code Review almost 13 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8998

Actions #6

Updated by Stanislas Rolland almost 13 years ago

The problem is that the place holder for the translated element is in the default language.

The proposed change does not modify the reported behaviour.

Actions #7

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8998

Actions #8

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9473

Actions #10

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/11684

Actions #12

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/11707

Actions #13

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/13009

Actions #14

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13010

Actions #15

Updated by Tolleiv Nietsch about 12 years ago

  • Status changed from Under Review to Resolved
Actions #16

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #17

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #18

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF