Feature #35245

Epic #58282: Workspaces Workpackage #2

Story #60008: Visual enhancements

Rework workspace notification settings

Added by Oliver Hader over 7 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2012-03-26
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Different notifications on stages

Currently there are several notification settings for these stages:
  • edit stage: takes recipients from "adminusers" (workspace owners)
  • "ready to publish" stage: takes recipients from "members" (workspace members)

However, the "execute publish" stage is not considered here.

Different behaviors for each stage

Each stage has to possibility to define "default users" with the following behavior:
  • all (non-strict)
    • if users from workspace setting (field "adminusers" or "members") which are also in the specific "default_users" setting for the stage, the checkbox is enabled by default and cannot be changed - otherwise it's not checked
  • all (strict)
    • all users from workspace setting (field "adminusers" or "members") are checked and cannot be changed
  • some (whatever "some" should mean in general)
    • all users from workspace setting (field "adminusers" or "members") are checked, but still can be changed

So, the specific "default_users" is just used in one case. Besides that, default_users and the workspaces settings are not merged - if there's no intersection for the mode "all (non-strict)" no recipient is checked per default.

More flexible approach

A more flexible approach would be to define (for each stage, plus the "execute publish" state and the individual stages):
  • that nobody is selected per default
  • the everybody is selected per default (standard case)
  • the initial author of a change is included
  • the workspace owners are included (currently this is only the case if "ready to publish" or "publish execute"
  • whether the selected elements can be unchecked again (protected mode)

Draft

See https://github.com/ohader/irre_workspaces/blob/master/Classes/Service/BehaviourService.php for a first draft implementation to e.g. resolve editors for each element. Using domain models or at least virtual containers for live/version records seems to be a first requirement.

35245_workspace.png View (70.1 KB) Oliver Hader, 2014-07-02 09:19

35245_stage.png View (53.4 KB) Oliver Hader, 2014-07-02 09:19


Related issues

Related to TYPO3 Core - Feature #35246: Make use of Extbase features Closed 2012-03-26
Related to TYPO3 Core - Bug #66361: Workspaces: Email Notifications are always sent to members of the current workspace, NOT the selected workspace. Closed 2015-04-10
Related to TYPO3 Core - Task #72395: Mark out-dated workspaces parts as deprecated Closed 2015-12-22
Related to TYPO3 Core - Task #72464: Remove deprecated code from ext:workspaces Closed 2015-12-29
Duplicated by TYPO3 Core - Bug #42336: Disabled users shown in notification list for stage changes Closed 2012-10-24

Associated revisions

Revision 1deec2d4 (diff)
Added by Oliver Hader about 4 years ago

[FEATURE] Rework workspace notification settings

The current notification settings have some drawbacks and are not
easy to understand if it comes the the expected behavior in the
workspace module. The settings are defined in each sys_workspace
and sys_workspace_stage record and are evaluated in the workspace
module if sending a particular element to be reviewed to the
previous or next stage.

This change extends the meaning and configuration possibilities
on defining the notification settings. In general the notification
modes are replaced by the definition whether the notification
dialog shall be shown and if the preselection can be changed.
Besides that, the preselection is cumulative and defined by
owners, members, editors and responsible persons (for stages).

Resolves: #35245
Releases: master
Change-Id: Icb680fe85fab61a51d53e3afb94b51a4930e180c
Reviewed-on: http://review.typo3.org/31160
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Oliver Hader over 7 years ago

  • File issue_35245.png added

#2 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9890

#3 Updated by Michael Stucki almost 6 years ago

  • Category changed from New Features to Workspaces

#4 Updated by Michael Stucki almost 6 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#5 Updated by Oliver Hader over 5 years ago

  • Subject changed from Rework notification settings to Rework workspace notification settings

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31160

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31160

#8 Updated by Oliver Hader over 5 years ago

  • Parent task set to #60008

#9 Updated by Oliver Hader over 5 years ago

  • File deleted (issue_35245.png)

#11 Updated by Oliver Hader over 5 years ago

Workspace

Stage

#12 Updated by Oliver Hader about 5 years ago

  • Tracker changed from Task to Feature

#13 Updated by Mathias Schreiber over 4 years ago

  • Target version changed from 6.0.0 to 7.5

#14 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#15 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#16 Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#17 Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#18 Updated by Benni Mack about 4 years ago

  • Target version changed from 7.5 to 7 LTS

#19 Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#20 Updated by Gerrit Code Review about 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31160

#21 Updated by Oliver Hader about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#22 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF