Project

General

Profile

Actions
Copy link

Bug #36934

closed

Cache RedisBackend using fixed databases for testing - NOT GOOD

Added by Anonymous over 12 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2012-05-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
tests
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hi,

In the file: ===
/t3lib/cache/backend/class.t3lib_cache_backend_RedisBackend.php ===

There is the following sentence: ===
The unit tests use and flush database numbers 0 and 1, production use should start from 2. ===

This is not a very good idea for servers, which already utilise an existing Redis databases. For example, we are using some 30 existing databases in Redis.

The last thing one wants is to have random flushing of unrelated databases.

=======================================
Solution:
Even testing databases should be set by the Typo3 user, and not pre-set.

Thank you for paying attention to this issue [which may create nasty surprises].

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #85563: Run core tests on new bamboo infrastructureClosed2018-07-15

Actions
Actions
Copy link
 #1

Updated by Christian Kuhn over 12 years ago

I'm aware of the problem. How to solve it?

Actions
Copy link
 #2

Updated by Anonymous over 12 years ago

Hi Christian,

I would suggest a new, either required or optional, option for testing databases. If none is supplied, no testing may occur.

Kind regards,

Actions
Copy link
 #3

Updated by Anonymous over 12 years ago

I mean something like:

$TYPO3_CONF_VARS['SYS']['caching']['cacheConfigurations']['cache_pages']['options']['testDatabases'] = '8,9';

Actions
Copy link
 #4

Updated by Philipp Gampe over 12 years ago

Christian: I agree to only test if someone sets up the test database. Putting this into $TYPO3_CONF_VARS sounds good too.

Actions
Copy link
 #5

Updated by Ingo Schmitt almost 11 years ago

  • Category set to Caching
  • Is Regression set to No
Actions
Copy link
 #6

Updated by Mathias Schreiber almost 10 years ago

  • Category changed from Caching to Tests
  • Target version set to 7.4 (Backend)
Actions
Copy link
 #7

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions
Copy link
 #8

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7 LTS
Actions
Copy link
 #9

Updated by Mathias Schreiber about 9 years ago

  • Target version deleted (7 LTS)
Actions
Copy link
 #10

Updated by Susanne Moog about 7 years ago

  • Status changed from New to Accepted

After talking with Lolli we came up with the following concept / steps:

  1. Allow the loading of a custom LocalConfiguration file which overwrites previous set settings to be able to modify testing configuration
  2. Rewrite the redis tests actually talking to redis as functional tests which use their own caching configuration incl. frontend - which allows ovrwriting the connection and database via 1
Actions
Copy link
 #11

Updated by Susanne Moog about 7 years ago

  • Tags set to testing-framework
Actions
Copy link
 #12

Updated by Susanne Moog about 7 years ago

  • Tags changed from testing-framework to tests

The Config part will be taken care of in https://github.com/TYPO3/testing-framework/issues/40

Todo here is now only the rewrite of the redis tests - after https://github.com/TYPO3/testing-framework/issues/40 is done.

Actions
Copy link
 #13

Updated by Christian Kuhn over 6 years ago

  • Related to Task #85563: Run core tests on new bamboo infrastructure added
Actions
Copy link
 #14

Updated by Christian Kuhn over 6 years ago

this will be solved with 'new bamboo infrastructure': the redis & memcache tests now require an environment variable that defines the redis / memcache host and optionally port. if not set, tests are skipped.

Actions
Copy link
 #15

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57522

Actions
Copy link
 #16

Updated by Christian Kuhn over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #17

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #18

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #19

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #20

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #21

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #22

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #23

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #24

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #25

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #26

Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604

Actions
Copy link
 #27

Updated by Christian Kuhn over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #28

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605

Actions
Copy link
 #29

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605

Actions
Copy link
 #30

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605

Actions
Copy link
 #31

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605

Actions
Copy link
 #32

Updated by Christian Kuhn over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #33

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #34

Updated by Stephan Großberndt over 4 years ago

  • Description updated (diff)
Actions
Copy link

Also available in: Atom PDF