Bug #36934
closed
Cache RedisBackend using fixed databases for testing - NOT GOOD
Added by Anonymous over 12 years ago. Updated over 4 years ago.
100%
Description
Hi,
In the file:
===
/t3lib/cache/backend/class.t3lib_cache_backend_RedisBackend.php
===
There is the following sentence:
===
The unit tests use and flush database numbers 0 and 1, production use should start from 2.
===
This is not a very good idea for servers, which already utilise an existing Redis databases. For example, we are using some 30 existing databases in Redis.
The last thing one wants is to have random flushing of unrelated databases.
=======================================
Solution:
Even testing databases should be set by the Typo3 user, and not pre-set.
Thank you for paying attention to this issue [which may create nasty surprises].
Updated by Christian Kuhn over 12 years ago
I'm aware of the problem. How to solve it?
Updated by Anonymous over 12 years ago
Hi Christian,
I would suggest a new, either required or optional, option for testing databases. If none is supplied, no testing may occur.
Kind regards,
Updated by Anonymous over 12 years ago
I mean something like:
$TYPO3_CONF_VARS['SYS']['caching']['cacheConfigurations']['cache_pages']['options']['testDatabases'] = '8,9';
Updated by Philipp Gampe over 12 years ago
Christian: I agree to only test if someone sets up the test database. Putting this into $TYPO3_CONF_VARS sounds good too.
Updated by Ingo Schmitt almost 11 years ago
- Category set to Caching
- Is Regression set to No
Updated by Mathias Schreiber almost 10 years ago
- Category changed from Caching to Tests
- Target version set to 7.4 (Backend)
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Benni Mack about 9 years ago
- Target version changed from 7.5 to 7 LTS
Updated by Susanne Moog about 7 years ago
- Status changed from New to Accepted
After talking with Lolli we came up with the following concept / steps:
- Allow the loading of a custom LocalConfiguration file which overwrites previous set settings to be able to modify testing configuration
- Rewrite the redis tests actually talking to redis as functional tests which use their own caching configuration incl. frontend - which allows ovrwriting the connection and database via 1
Updated by Susanne Moog about 7 years ago
- Tags changed from testing-framework to tests
The Config part will be taken care of in https://github.com/TYPO3/testing-framework/issues/40
Todo here is now only the rewrite of the redis tests - after https://github.com/TYPO3/testing-framework/issues/40 is done.
Updated by Christian Kuhn over 6 years ago
- Related to Task #85563: Run core tests on new bamboo infrastructure added
Updated by Christian Kuhn over 6 years ago
this will be solved with 'new bamboo infrastructure': the redis & memcache tests now require an environment variable that defines the redis / memcache host and optionally port. if not set, tests are skipped.
Updated by Gerrit Code Review over 6 years ago
- Status changed from Accepted to Under Review
Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57522
Updated by Christian Kuhn over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 18193657f61cea5eed05b1b1d8420c872f1311cf.
Updated by Gerrit Code Review over 6 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 7 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 8 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 9 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Gerrit Code Review over 6 years ago
Patch set 10 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57604
Updated by Christian Kuhn over 6 years ago
- Status changed from Under Review to Resolved
Applied in changeset dfcd57185ce9b9996b3daa43aa24ec5484bba2e6.
Updated by Gerrit Code Review over 6 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57605
Updated by Christian Kuhn over 6 years ago
- Status changed from Under Review to Resolved
Applied in changeset 12d723f7dae37022296c6992cc3173714416de4d.
Updated by