Bug #38496: Redirect of a shortcut does not take all URL parameters into account - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Markus Timtner

Actions

Copy link

Bug #38496

closed

Redirect of a shortcut does not take all URL parameters into account

Added by Helmut Hummel about 12 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Susanne Moog

Category:

Target version:

8.4

Start date:

2012-06-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.0

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

On Location Sprint

Description

Currently when a page is a shortcut, TYPO3 redirects to the page the shortcut points to.
But only configured linkVars and the type parameter are taken into account for generating the target link.
Any additional parameter that is appended to the URL of a shortcut page is discarded.

The solution is to just forward every GET parameter to the target page.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #34642: Shortcut redirects might loose linkVars

Closed

2012-03-07

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Helmut Hummel over 11 years ago

Target version changed from 6.0.0-alpha3 to 6.0.1

Actions

Copy link

Updated by Markus Klein almost 10 years ago

Target version changed from 6.0.1 to next-patchlevel
Is Regression set to No

Actions

Copy link

Updated by Sergio Catalá almost 9 years ago

Assignee set to Susanne Moog

Susanne, we were talking yesterday about this issue. I am not able to patch it properly :(
Looking at this code under typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php file (lines from 3008 to 3012):

$type = GeneralUtility::_GET('type');
if ($type && MathUtility::canBeInterpretedAsInteger($type)) {
  $parameter .= ',' . $type;
}
$redirectUrl = $cObj->typoLink_URL(array('parameter' => $parameter));

I would replace for something like this:

$arguments = GeneralUtility::_GET();
unset($arguments['id']);
if (count($arguments)) {
  foreach ($arguments as $argument) {
    $parameter .= ',' . $argument;
  }
}

But as far as I can see, this is later used inside typolink function, that is a bit tricky.

Could you take a look?

Actions

Copy link

Updated by Helmut Hummel almost 9 years ago

imho it would be enough to add the config option "addQueryString" to the typolink call

Actions

Copy link

Updated by Mathias Schreiber over 8 years ago

Target version deleted (~~next-patchlevel~~)

Actions

Copy link

Updated by Susanne Moog almost 8 years ago

Target version set to 8.4
Sprint Focus set to On Location Sprint

Actions

Copy link

Updated by Tomita Militaru almost 8 years ago

I am working on this one.

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49785

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49785

Actions

Copy link

#10

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49785

Actions

Copy link

#11

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49785

Actions

Copy link

#12

Updated by Gerrit Code Review almost 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49785

Actions

Copy link

#13

Updated by Tomita Militaru almost 8 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 11e8de8d0d36982bdce6e2dc20db865f5df67c68.

Actions

Copy link

#14

Updated by Markus Timtner over 7 years ago

This fix is still not present in current v7 LTS branch!

Actions

Copy link

#15

Updated by Susanne Moog over 7 years ago

This ticket will not be merged to the 7.6 LTS branch as it is a breaking change. See https://docs.typo3.org/typo3cms/extensions/core/8-dev/Changelog/8.4/Breaking-38496-AddAllParametersToAShortcutPage.html

If you need this fix, you could either upgrade to the 8 branch or patch your core version accordingly.

Actions

Copy link

#16

Updated by Markus Timtner over 7 years ago

Hi Susanne,
thanks for the info. I wasn't aware of this being a breaking change...
I have patched my core version accordingly, didn't seem to have any negative side-effects.

Actions

Copy link

#17

Updated by Riccardo De Contardi over 6 years ago

Status changed from Resolved to Closed

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

TYPO3 Core

Custom queries

Watchers (1)

Bug #38496

Redirect of a shortcut does not take all URL parameters into account

Updated by Helmut Hummel over 11 years ago

Updated by Markus Klein almost 10 years ago

Updated by Sergio Catalá almost 9 years ago

Updated by Helmut Hummel almost 9 years ago

Updated by Mathias Schreiber over 8 years ago

Updated by Susanne Moog almost 8 years ago

Updated by Tomita Militaru almost 8 years ago

Updated by Gerrit Code Review almost 8 years ago

Updated by Gerrit Code Review almost 8 years ago

Updated by Gerrit Code Review almost 8 years ago

Updated by Gerrit Code Review almost 8 years ago

Updated by Gerrit Code Review almost 8 years ago

Updated by Tomita Militaru almost 8 years ago

Updated by Markus Timtner over 7 years ago

Updated by Susanne Moog over 7 years ago

Updated by Markus Timtner over 7 years ago

Updated by Riccardo De Contardi over 6 years ago