Project

General

Profile

Actions

Bug #41045

closed

Delete modified page in workspace just reverts changes

Added by Heiko Kromm about 12 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-09-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

I edited page properties in a workspace and did not publish them.
After that, I decided to delete the page in the workspace.
The page will not be marked as deleted and the property changes made before are lost.
Althought the page is deleted from pagetree, but will show again after reloading the pagetree.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #52700: Change delete icon in context menu if record is deletedClosed2013-10-062013-10-06

Actions
Actions #1

Updated by Oliver Hader about 12 years ago

  • Status changed from New to Accepted
  • Target version set to 4.5.20
Actions #2

Updated by Oliver Hader about 12 years ago

The "delete" action on modified workspace contents is "revert"...
IMO The "revert" action only shall take place in the workspace module - any other action should be the default behaviour

Actions #3

Updated by Oliver Hader about 12 years ago

  • Subject changed from Delete page in workspace when previously edited will fail to Delete modified page in workspace just reverts changes
Actions #4

Updated by Oliver Hader about 12 years ago

I modified the title, since the action does not fail - just an additional step is required

  1. delete -> revert changes
  2. delete -> registers page to be deleted for next publishing procedure
Actions #5

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #6

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #7

Updated by Mathias Schreiber almost 10 years ago

  • Target version changed from 4.5.20 to 7.5
Actions #8

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7 LTS
Actions #9

Updated by Mathias Schreiber about 9 years ago

  • Target version deleted (7 LTS)
Actions #10

Updated by Riccardo De Contardi almost 7 years ago

  • Related to Bug #52700: Change delete icon in context menu if record is deleted added
Actions #11

Updated by Riccardo De Contardi almost 7 years ago

I've performed the following test with 8.7.9:

Prerequisites

- Fresh TYPO3 8.7.9 installation
- a "custom" workspace

Test procedure

- Live Workspace
- create a page "Test", edit its subheader and write "Test"
- go to "custom" workspace
- edit the page and change the subheader to "NEW Test"
- click on delete (I tried with the context menu in pagetree and in list view)

Results:

- the page still appears in the pagetree
- the changes in the subheader fields are still there
- to remove the page you have to publish it. then it is also removed from the pagetree.

Notes

- using the list view (from the parent page) to delete the page, I noticed that the page is removed from the list, but when refreshing the list view, it appears again
- using the pagetree context menu in the "custom" workspace, I noticed that you could delete the page again. Actually, that action is a restore - this is related to #52700

Actions #12

Updated by Christian Kuhn over 4 years ago

Checked again in v11: If a page is deleted in workspaces (a delete placeholder for that page is created), it is no longer shown in the page tree. Only the list module then allows to restore the page. Note on restore, modifications that may have been done to the record in workspaces get lost (this might be intended).

All in all, the restore functionality is imho quite hard to understand for editors. We may discuss to either improve or drop this feature ux wise.

Note: in v9, a restored page does not show up in pagetree again (guess: the query misses deleted=1 for ws pages, so it thinks the page is still deleted). This however has been fixed in v10 at some point (and will no longer be fixed in v9).

However, the initial issue 'page still shown in page tree after delete in workspace' has been solved meanwhile. I'd thus close this issue now - if we want to review the restore functionality, this should happen in new issues.

Actions #13

Updated by Christian Kuhn over 4 years ago

  • Status changed from Accepted to Closed

Closing issue - it seems to have been solved meanwhile.

Note on the 'list-module-delete-ajax': This is quite broken, especially in workspace context ... This would need separate issues to see how it can be improved or dropped.

Actions

Also available in: Atom PDF