Project

General

Profile

Actions

Bug #41327

closed

jsInline removes closing brackets

Added by Simon Schaufelberger over 11 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Category:
TypoScript
Target version:
-
Start date:
2012-09-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
nightmare
Is Regression:
No
Sprint Focus:

Description

this code does NOT work:

page.jsInline {
    10 = TEXT
    10.value (
        jquery(document).ready(function($) {
            $('.pagination li').hover(
                function(){}
            );
        });
    )
}

broken output:
jquery(document).ready(function($) {
    $('.pagination li').hover(
        function(){}

but this one does (notice the last line):

page.jsInline {
    10 = TEXT
    10.value (
        jquery(document).ready(function($) {
            $('.pagination li').hover(
                function(){});});
    )
}

i guess TYPO3 somehow interprets the last closing brackets as the closing bracket for the 10.value which is really strange.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #76447: TypoScript Parse BugClosed2016-06-03

Actions
Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Actions #1

Updated by Stefan Galinski over 11 years ago

  • Status changed from New to Accepted

Just reproduced this example with the current master. Also if this can maybe fixed, I don' think that the parser can ever work perfectly for such constructs if there isn't something like a CDATA section in XML for such kind of inline code to indicate the parser to not parse the inner content for syntax elements except the ending marker.

Actions #2

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 7.2 (Frontend)
  • Complexity set to nightmare
  • Is Regression set to No
Actions #3

Updated by Riccardo De Contardi almost 9 years ago

  • Status changed from Accepted to Needs Feedback
  • Assignee set to Simon Schaufelberger

Hi Simon, I am looking at your initial javascript code, and I think there is an error: shouldn't it be:

jquery(document).ready(function($) {
    $('.pagination li').hover(
        function(){$(this).not('.current').find('em').stop().animate({left: "0px"}, 300)},
        function(){$(this).not('.current').find('em').stop().animate({left: "-270px"}, 300)} /*<< here a "}" seems necessary */
    );
}); 

? The second code has the same problem, I think.
Actions #4

Updated by Riccardo De Contardi almost 9 years ago

  • Status changed from Needs Feedback to Accepted
  • Assignee changed from Simon Schaufelberger to Benni Mack
  • TYPO3 Version changed from 4.7 to 6.2

The bug is still present in 6.2.12 and seems indipendent from the lack of the "}" I noticed.

Actions #5

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39596

Actions #6

Updated by Benni Mack almost 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Actions #7

Updated by Benni Mack almost 9 years ago

  • Status changed from Under Review to Accepted
  • Target version changed from 7.4 (Backend) to 7 LTS
Actions #8

Updated by Benni Mack over 8 years ago

  • Target version deleted (7 LTS)
Actions #9

Updated by Simon Schaufelberger about 5 years ago

  • Description updated (diff)
Actions #10

Updated by Benni Mack about 4 years ago

  • Related to Bug #76447: TypoScript Parse Bug added
Actions #11

Updated by Simon Schaufelberger almost 2 years ago

  • Description updated (diff)
Actions #12

Updated by Simon Schaufelberger almost 2 years ago

  • Description updated (diff)
Actions #13

Updated by Simon Schaufelberger almost 2 years ago

  • Description updated (diff)
Actions #14

Updated by Simon Schaufelberger almost 2 years ago

  • Assignee changed from Benni Mack to Christian Kuhn
Actions #15

Updated by Christian Kuhn almost 2 years ago

Actions #16

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #17

Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #18

Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #19

Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #20

Updated by Christian Kuhn almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF