Project

General

Profile

Actions

Task #53514

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

Extbase: DataMapper causes redundant queries

Added by Nico de Haen over 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Extbase
Target version:
Start date:
2013-11-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

The thawProperties method of the DataMapper does not check the identity map before retrieving the property value with fetchRelated. This results in redundant queries on the same table with the same addWhere. For example SELECT tx_foo_domain_model_bar.* FROM tx_foo_domain_model_bar WHERE uid IN ('1')


Files

ztest.zip (660 KB) ztest.zip Nico de Haen, 2014-01-18 00:04

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple timesClosedFelix Oertel2014-03-202014-03-20

Actions
Related to TYPO3 Core - Bug #56442: Invalid FileReference usedClosedXavier Perseguers2014-02-28

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #3

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #4

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #5

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #6

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #7

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #9

Updated by Nico de Haen over 10 years ago

Here is a small demo extension to test the gerrit patch.

Father has a n:1 relation to child1. If there are 2 (or more) fathers with a relation to child with uid 1 it will result in 2 (or more) identical queries

SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('1') 

If there are 2 (or more) fathers with a relation to child with uid 1 it will result in a 2 (or more) identical queries
SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('0') 

Actions #10

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #11

Updated by Felix Oertel over 10 years ago

  • Parent task set to #55168
Actions #12

Updated by Felix Oertel over 10 years ago

  • Assignee set to Nico de Haen
Actions #13

Updated by Gerrit Code Review over 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions #14

Updated by Ernesto Baschny over 10 years ago

  • Project changed from 534 to TYPO3 Core
  • Category deleted (Extbase: Generic Persistence)
Actions #15

Updated by Ernesto Baschny over 10 years ago

  • Category set to Extbase
  • TYPO3 Version set to 6.2
Actions #16

Updated by Ernesto Baschny over 10 years ago

  • Subject changed from DataMapper causes redundant queries to Extbase: DataMapper causes redundant queries
Actions #17

Updated by Nico de Haen over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #18

Updated by Riccardo De Contardi almost 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF