Task #53514
closed
Epic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Epic #55656: Optimize overall Extbase performance
Story #55168: Optimize Extbase generic persistence
Extbase: DataMapper causes redundant queries
100%
Description
The thawProperties method of the DataMapper does not check the identity map before retrieving the property value with fetchRelated. This results in redundant queries on the same table with the same addWhere. For example SELECT tx_foo_domain_model_bar.* FROM tx_foo_domain_model_bar WHERE uid IN ('1')
Files
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Gerrit Code Review about 11 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Nico de Haen about 11 years ago
Here is a small demo extension to test the gerrit patch.
Father has a n:1 relation to child1. If there are 2 (or more) fathers with a relation to child with uid 1 it will result in 2 (or more) identical queries
SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('1')
If there are 2 (or more) fathers with a relation to child with uid 1 it will result in a 2 (or more) identical queries
SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('0')
Updated by Gerrit Code Review about 11 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by
Updated by Gerrit Code Review almost 11 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252
Updated by Ernesto Baschny almost 11 years ago
- Project changed from 534 to TYPO3 Core
- Category deleted (
Extbase: Generic Persistence)
Updated by Ernesto Baschny almost 11 years ago
- Category set to Extbase
- TYPO3 Version set to 6.2
Updated by Ernesto Baschny almost 11 years ago
- Subject changed from DataMapper causes redundant queries to Extbase: DataMapper causes redundant queries
Updated by Nico de Haen almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset faa6e8a6a38698a814e64f6f2276f4afd415c485.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed