Task #53514: Extbase: DataMapper causes redundant queries - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Task #53514

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

Extbase: DataMapper causes redundant queries

Added by Nico de Haen over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Nico de Haen

Category:

Extbase

Target version:

6.2.0

Start date:

2013-11-11

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

medium

Sprint Focus:

Description

The thawProperties method of the DataMapper does not check the identity map before retrieving the property value with fetchRelated. This results in redundant queries on the same table with the same addWhere. For example SELECT tx_foo_domain_model_bar.* FROM tx_foo_domain_model_bar WHERE uid IN ('1')

Files

ztest.zip (660 KB) ztest.zip

Nico de Haen, 2014-01-18 00:04

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple times

Closed

Felix Oertel

2014-03-20

Actions

Related to TYPO3 Core - Bug #56442: Invalid FileReference used

Closed

Xavier Perseguers

2014-02-28

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

Updated by Nico de Haen over 10 years ago

File ztest.zip ztest.zip added

Here is a small demo extension to test the gerrit patch.

Father has a n:1 relation to child1. If there are 2 (or more) fathers with a relation to child with uid 1 it will result in 2 (or more) identical queries

SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('1')

If there are 2 (or more) fathers with a relation to child with uid 1 it will result in a 2 (or more) identical queries

SELECT tx_ztest_domain_model_child1.* FROM tx_ztest_domain_model_child1 WHERE tx_ztest_domain_model_child1.uid IN ('0')

Actions

Copy link

#10

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

#11

Updated by Felix Oertel over 10 years ago

Parent task set to #55168

Actions

Copy link

#12

Updated by Felix Oertel over 10 years ago

Assignee set to Nico de Haen

Actions

Copy link

#13

Updated by Gerrit Code Review over 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25252

Actions

Copy link

#14