Task #55532

Epic #55070: Workpackages

Epic #54542: WP: Importer / Exporter with relations MM/IRRE/FAL

Story #55520: As an User I want to create exports in v. 6.2 and import them in v. 6.2

Impexp: import the binary files being sys_file records to the right storage

Added by Marc Bastian Heinrichs over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Import/Export (T3D)
Target version:
Start date:
2014-01-31
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

General: the Datahandler should not be used to import sys_file records.

The files and sys_file records should be written using the FAL API.

A) The FAL handling must be done before $this->writeRecords_records($pid);
B) import contains a sys_file_storage record:
  • Check if driver is Local
  • Not Local: use Default storage for import
  • Local: check for identical storage (same basePath/pathType)
  • identical: use the present one
  • not identical: import, save new ID and use it (add option to force the default)
C) remove sys_file_storage entries from header records
D) Loop through sys_file records
  • init storage
  • use imported storage, use identical present one, use the default one or fetch the best one for the identifier
  • before save: check if there is a file with same identifier and same same hash
  • save map from old ids to new ids

E) remove sys_file entries from header records


Related issues

Related to TYPO3 Core - Task #55431: Impexp: file contents of sys_file are not included in export Closed 2014-01-29
Related to TYPO3 Core - Task #55528: Importing a identical sys_file_storage have to be prevented Closed 2014-01-31
Related to TYPO3 Core - Task #55526: Impexp: missing fields of sys_file on import Rejected 2014-01-31
Related to TYPO3 Core - Task #55906: Impext: Don't clear relation field data for sys_file_reference uid_local Closed 2014-02-11
Related to TYPO3 Core - Task #49227: Files missing in import/export Closed 2013-06-18
Related to TYPO3 Core - Bug #81277: Import tests with side effects Accepted 2017-05-19

Associated revisions

Revision 6d04aab0 (diff)
Added by Marc Bastian Heinrichs over 5 years ago

[TASK] Add FAL support for import in sys extension impexp

Until now only files from TCA type group internal_type file or
file_reference could be imported and exports from version 6.x
including sys_file records leads to exceptions on importing.
The patch adds support for handling record types introduced
with the File Abstraction Layer.

Resolves: #55532
Resolves: #55528
Resolves: #55906
Releases: 6.2
Change-Id: I7521c84094b0a0424e13c5f91c26b630bbbccbfe
Reviewed-on: https://review.typo3.org/27836
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#3 Updated by Marc Bastian Heinrichs over 5 years ago

  • % Done changed from 0 to 80

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27836

#9 Updated by Marc Bastian Heinrichs over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100

#10 Updated by Anja Leichsenring over 3 years ago

  • Sprint Focus set to On Location Sprint

#11 Updated by Mathias Schreiber over 3 years ago

  • Sprint Focus deleted (On Location Sprint)

#12 Updated by Oliver Hader over 2 years ago

  • Related to Bug #81277: Import tests with side effects added

#13 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF