Task #56177

Epic #55070: Workpackages

Epic #54851: WP: Workspaces IRRE & MM bugfixes

Epic #55064: WP: Workspaces test cases / DataHandler bugfixes

Windows issues with long CSV file name from commit 2db3d30

Added by Mathias Brodala over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Tests
Target version:
Start date:
2014-02-21
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The commit 2db3d30 added the following file:

typo3/sysext/workspaces/Tests/Functional/DataHandling/InlineRelationalRecordEditing/CommaSeparatedValue/DataSet/Assertion/createAndLocalizeParentContentRecordWithHotelAndOfferChildRecordsAndDiscardLocalizedParentRecord.csv

It seems like this file path is too long for either Windows or Git on Windows. If you pull/merge this commit, the file cannot be created, if you do a clean clone, this file is deleted immediately and cannot be restored.

Suggestion: use a shorter file name.

modify.sh View - File Name Modification (1.33 KB) Oliver Hader, 2014-02-24 15:24


Related issues

Related to TYPO3 Core - Task #56072: Extend DataHandler IRRE functional tests Closed 2014-02-18
Related to TYPO3 Core - Task #56143: Integrate IRRE CSV Functional Tests Closed 2014-02-20

Associated revisions

Revision 77e287f7 (diff)
Added by Oliver Hader over 5 years ago

[TASK] Windows issues with long file names in Git sources

The recent DataHander functional tests integrate file names that
are very long since they contain a description of what actually
is expected in the accordant test assertion file.

However, Windows has a limit of 260 characters per file path.
The longest file path of the mentioned functional tests has been
223 characters and is now reduced to 166 characters.

Resolves: #56177
Releases: 6.2
Change-Id: I1490a3f0fae7ef40547d81e304cb98077ab6142b
Reviewed-on: https://review.typo3.org/27815
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

History

#1 Updated by Eric Chavaillaz over 5 years ago

Windows allows something like this on NTFS partition :

C:\<256 character length><NULL>

The file in question is long of 223 characters.

So if you got something like C:\Users\Your Name\Documents\Git\typo3_src-git\typo3..., the length will be 223 + 45 (Users\Your Name\Documents\Git\typo3_src-git\) = 268 characters.

It's too long. You can move the location of your Git repository in local to solve quickly the problem.

But I agree that this file is too long!

#2 Updated by Philipp Gampe over 5 years ago

  • Status changed from New to Accepted

More information on windows path limitations: http://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx

The nineties strike back! Yeah.

One would assume that modern operating systems and shells as well as GUIs support more than byte long path pointers, but well ... we need to fix this.

#3 Updated by Philipp Gampe over 5 years ago

  • Category changed from Miscellaneous to Tests
  • Assignee set to Oliver Hader
  • Target version set to 6.2.0

#4 Updated by Marc Bastian Heinrichs over 5 years ago

commit cac662a2d8 has already too long file paths.

#5 Updated by Nicole Cordes over 5 years ago

With commit 092b8d0 the files are introduced!

#6 Updated by Oliver Hader over 5 years ago

  • Tracker changed from Bug to Task

#7 Updated by Oliver Hader over 5 years ago

#8 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27815

#9 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27815

#10 Updated by Oliver Hader over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Oliver Hader over 5 years ago

  • Parent task set to #55064
  • PHP Version set to 5.3

#12 Updated by alex pablate over 5 years ago

Use long path tool for such problems.

#13 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF