Project

General

Profile

Actions

Bug #59587

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Performance killer: APC cache backend, wrong assignment of cache tags

Added by Florian Schwaiger over 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Caching
Target version:
-
Start date:
2014-06-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

It adds way too many tags to the "ident_..." entries due to wrong usage of for loop. This results in ident-to-tag-mappings that are larger than the actual cache entries themselves.

Check the attached patch which solves the bug.
Please merge the fix soon so we can update our server.


Files

apc-tags-patch.diff (808 Bytes) apc-tags-patch.diff Florian Schwaiger, 2014-06-15 17:58

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #62513: Backport #59587 to TYPO3 4.5Closed2014-10-28

Actions
Actions #1

Updated by Alexander Opitz over 10 years ago

  • Status changed from New to Accepted
  • Assignee set to Alexander Opitz
  • Complexity changed from no-brainer to easy

By reading the code, this solution seams not correct course the source around also isn't correct, a copy&paste error IMHO.

One line above:

if (array_search($entryIdentifier, $existingTags) === FALSE) {

Why do we search the identifier in the existingTags? This should fail every time.

And again one line upper:

$existingTags = $this->findTagsByIdentifier($entryIdentifier);

Why should we search for all tags in every loop? We know them after first access.

Actions #2

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #3

Updated by Alexander Opitz over 10 years ago

  • Status changed from Under Review to Accepted
  • Parent task set to #55065
Actions #4

Updated by Alexander Opitz over 10 years ago

This issue also applies to Memcached/Wincache/Xcache

Actions #5

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #6

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #7

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #9

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #10

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #11

Updated by Gerrit Code Review over 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #12

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #13

Updated by Gerrit Code Review over 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #14

Updated by Oliver Hader over 10 years ago

  • Complexity changed from easy to medium
Actions #15

Updated by Gerrit Code Review over 10 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #16

Updated by Gerrit Code Review over 10 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767

Actions #17

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31518

Actions #18

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31519

Actions #19

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31518

Actions #20

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31520

Actions #21

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31521

Actions #22

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31522

Actions #23

Updated by Markus Klein over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #24

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF