Bug #59587
closed
Epic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Performance killer: APC cache backend, wrong assignment of cache tags
Added by Florian Schwaiger almost 10 years ago. Updated over 5 years ago.
100%
Description
It adds way too many tags to the "ident_..." entries due to wrong usage of for loop. This results in ident-to-tag-mappings that are larger than the actual cache entries themselves.
Check the attached patch which solves the bug.
Please merge the fix soon so we can update our server.
Files
| apc-tags-patch.diff (808 Bytes) apc-tags-patch.diff | Florian Schwaiger, 2014-06-15 17:58 |
Updated by Alexander Opitz almost 10 years ago
- Status changed from New to Accepted
- Assignee set to Alexander Opitz
- Complexity changed from no-brainer to easy
By reading the code, this solution seams not correct course the source around also isn't correct, a copy&paste error IMHO.
One line above:
if (array_search($entryIdentifier, $existingTags) === FALSE) {
Why do we search the identifier in the existingTags? This should fail every time.
And again one line upper:
$existingTags = $this->findTagsByIdentifier($entryIdentifier);
Why should we search for all tags in every loop? We know them after first access.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Alexander Opitz almost 10 years ago
- Status changed from Under Review to Accepted
- Parent task set to #55065
Updated by Alexander Opitz almost 10 years ago
This issue also applies to Memcached/Wincache/Xcache
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Oliver Hader almost 10 years ago
- Complexity changed from easy to medium
Updated by Gerrit Code Review almost 10 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30767
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31518
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31519
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31518
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31520
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31521
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31522
Updated by Markus Klein almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 66d2354a1c505b7e64cc6422f75ce6983f1bcfcb.
Updated by