Project

General

Profile

Actions

Bug #59606

closed

[FEATURE] Integrate Symfony/Console into CommandController

Added by Stefano Kowalke almost 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2014-06-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

This is a backport from the new introduced feature in Flow [[https://review.typo3.org/#/c/30653/4]].

This extends the base ``CommandController`` by some convenience
helpers from the ``symfony/console`` package:
  • easy output coloring through "<error>Warning!</error>"
  • TableHelper to render values to a grid
  • ProgressHelper to render and advance and progress bars
  • DialogHelper with numerous types of questions like: select,
    ask, confirm, askHidden, etc
    Additionally this change improves the
    ``mapRequestArgumentsToControllerArguments()`` method to ask for
    missing required arguments instead of quitting with an exception.
    You can make use of the new features by calling the introduced
    proxy methods from within your CommandController:
  • outputTable()
  • select()
  • ask()
  • askConfirmation()
  • askHiddenResponse()
  • askAndValidate()
  • askHiddenResponseAndValidate()
  • progressStart()
  • progressSet()
  • progressAdvance()
  • progressFinish()
    This change does not alter the public API so it is not breaking
    in the strict sense. But it introduces a new behavior:
    Previously all outputs where collected in the ``Cli\Response``
    and only rendered to the console at the end of a CLI request.
    Now all methods producing output (inluding ``output()`` and
    ``outputLine()``) render the result directly to the console.
    If you use ``$this->response`` directly or let the command method
    return a string, the rendering is still deferred until the end of
    the CLI request.

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #60546: Flash message support for command controllersRejected2014-07-24

Actions
Actions #1

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30743

Actions #2

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30743

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30743

Actions #4

Updated by Mathias Schreiber over 9 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
Actions #5

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.3 (Packages)
Actions #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #7

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #8

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #9

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus set to On Location Sprint
Actions #10

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #11

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #12

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #13

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30743

Actions #14

Updated by Wouter Wolters almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Anja Leichsenring about 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #16

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF