TYPO3 Core

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30909

But this would basically require a clunky construct like this if all you care about is persisting an object, no matter if it is new or not:

if ($foo->_isNew()) {
  $this->fooRepository->add($foo);
} else {
  $this->fooRepository->update($foo);
}

Quite ugly if you ask me.

Also note that not even the Generic persistence manager in TYPO3 Flow cares about this. (I know that the Doctrine persistence manager does since #34527.)

I know it's not looking nice and I know I found it to be stupid some years ago myself. But ...

- first of all this was an unintentional side effect of some patches!
- it really sucks if you have a create/new style application, which is just intended to create fresh/new objects. Now you/developer must take care of securing your application so it can't be abused to modify arbitrary objects of the same type

I prefer ugly code over my data being open for unintentional manipulatation.

Until this get's cleaned I suggest everyone in create/new actions (that don't have any access check) to use something like:

if ((int)$myobject->getUid() > 1) throw new Exception("Error");
# somebody trìed to goof in an existing object

Hi!

Mathias Brodala wrote:

Also note that not even the Generic persistence manager in TYPO3 Flow cares about this.

Which is a bug

(I know that the Doctrine persistence manager does since #34527.)

.. which was only fixed in the Doctrine persistence manager

I agree with Peter, that the initial behavior (throwing an exception) should be restored.

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30909

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30909

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30909

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30909

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30909

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30909