Feature #61095

feedit - Bring back editNoPopup?

Added by Paul Golmann over 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-08-20
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

Hello!

First of all thanks @Gregor Ringer for your work on feedit!

I would like to know if you actually wanted to remove the configuration option `edit_editNoPopup` in the commit referenced below? Was it because of security (CSRF or so) issues? This option only changed the behavior of the frontend editing icon-buttons so that they open the edit form in the same window and not in a popup. The affected method `editPanelLinkWrap_doWrap` would only need a little work to bring back that feature.
In some of my projects I used this option and would like to continue to.

Related Commit: 545610af
Related Diff: lines 264 following https://forge.typo3.org/projects/typo3cms-core/repository/revisions/545610af1285629e8355aa6e1f7bdd06b4941026/diff/typo3/sysext/feedit/Classes/FrontendEditPanel.php
Related Issue; #49640

If you do not want this option back in the core anymore I would suggest updating the documentation (I can do a pull request for that):
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.edit.editNoPopup
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.forceNoPopup

Also there is another issue related: #43447
And another (old) issue complaining about the documentation: #23412


Related issues

Related to TYPO3 Core - Bug #23412: admPanel configuration by TSconfig is buggyClosed2010-08-20

Actions
Related to TYPO3 Core - Bug #43447: admPanel.override.edit.editNoPopup = 1 doesn't work Closed2012-11-29

Actions
Related to TYPO3 Core - Task #49640: Improve feedit & adminpanelClosedGeorg Ringer2013-07-03

Actions

Also available in: Atom PDF