Bug #69742
closedStory #69617: FormEngine bugs
Assigning Frontend Groups broken
Added by Morton Jonuschat about 9 years ago. Updated about 7 years ago.
100%
Description
The Multi-Select to set access restrictions on page level behaves weirdly.
1) Setting „Hide at login“ and saving the form shows „Hide at login“ twice in the selected options. The value in the DB is ok.
2) Adding a group when „Hide at login“ was selected adds the group in addition to the „Hide at login“
Updated by Michael Oehlhof about 9 years ago
- Status changed from New to In Progress
Updated by Christian Kuhn about 9 years ago
Yes. Seen that. This is probably "only" a display issue, but unfortunately not that easy to resolve.
This is caused by a trimExplode in TcaSelectValues that keeps empty entries. If that is removed (TRUE added iirc), then other select stuff behaves weird, instead. Reason is here that sometimes an empty value is ok (for static value lists) and sometimes it is not ok (for relations).
Problem is here that the two data provider TcaSelectItems and Values should probably be one provider, where the "static" list of valid values (entries coming from static item list, or are added via pageTs and friends) is determined and nailed, and after that the dynamic entries are determined.
- fetch items from static list (the first group of methods in TcaSelectItems)
- validate / determine values that fall are added by that
- fetch items from dynamic sources (foreign_table & friends)
- validate / determine values that are added by this category that did not fall into this the first area that.
At least that was my idea when i stumbled upon this issue. There is also a @todo in TcaSelectValues that says something similar. I think the former DataProprocessor code handled selectValues in a similar way as outlined above, but probably I unfortunately ignored this fact and now we have this issue ...
Updated by Christian Kuhn about 9 years ago
Also, this is what i think was required to fix this issue, but i'm also not 100% sure if that is the right track ... at least separating the 'static' value determination within databaseRow field from the 'dynamic' part should at least help to nail this issue a bit better.
Updated by Gerrit Code Review about 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Gerrit Code Review about 9 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278
Updated by Alexander Stehlik about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d1caf7688bde1c088c797668470c729a4688d3dd.
Updated by Gerrit Code Review about 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43319
Updated by Alexander Stehlik about 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset bb6064419d449e151535599a82a34e1fda675909.
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed