Project

General

Profile

Actions

Bug #69742

closed

Story #69617: FormEngine bugs

Assigning Frontend Groups broken

Added by Morton Jonuschat almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2015-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The Multi-Select to set access restrictions on page level behaves weirdly.

1) Setting „Hide at login“ and saving the form shows „Hide at login“ twice in the selected options. The value in the DB is ok.
2) Adding a group when „Hide at login“ was selected adds the group in addition to the „Hide at login“


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #69755: TCA select tree does not save multiple valuesClosed2015-09-13

Actions
Related to TYPO3 Core - Bug #69761: Backend group form displays invalid additional groupClosedAlexander Stehlik2015-09-13

Actions
Actions #1

Updated by Christian Kuhn almost 9 years ago

  • Parent task set to #69617
Actions #2

Updated by Michael Oehlhof almost 9 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Christian Kuhn almost 9 years ago

Yes. Seen that. This is probably "only" a display issue, but unfortunately not that easy to resolve.

This is caused by a trimExplode in TcaSelectValues that keeps empty entries. If that is removed (TRUE added iirc), then other select stuff behaves weird, instead. Reason is here that sometimes an empty value is ok (for static value lists) and sometimes it is not ok (for relations).

Problem is here that the two data provider TcaSelectItems and Values should probably be one provider, where the "static" list of valid values (entries coming from static item list, or are added via pageTs and friends) is determined and nailed, and after that the dynamic entries are determined.

  • fetch items from static list (the first group of methods in TcaSelectItems)
  • validate / determine values that fall are added by that
  • fetch items from dynamic sources (foreign_table & friends)
  • validate / determine values that are added by this category that did not fall into this the first area that.

At least that was my idea when i stumbled upon this issue. There is also a @todo in TcaSelectValues that says something similar. I think the former DataProprocessor code handled selectValues in a similar way as outlined above, but probably I unfortunately ignored this fact and now we have this issue ...

Actions #4

Updated by Christian Kuhn almost 9 years ago

Also, this is what i think was required to fix this issue, but i'm also not 100% sure if that is the right track ... at least separating the 'static' value determination within databaseRow field from the 'dynamic' part should at least help to nail this issue a bit better.

Actions #5

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #6

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #7

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #8

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #9

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #10

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #11

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #12

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #13

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #14

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #15

Updated by Gerrit Code Review over 8 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43278

Actions #16

Updated by Alexander Stehlik over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43319

Actions #18

Updated by Alexander Stehlik over 8 years ago

  • Status changed from Under Review to Resolved
Actions #19

Updated by Anja Leichsenring over 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #20

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF