Bug #71973

Sorting of file relations doesn't have any effect in a workspace

Added by Lorenz Ulrich over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2015-11-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Sorting file references, e.g. in a "file links" element, doesn't have any effect in a workspace. After saving, the sorting is just as it was before:


Files

workspaces-fal-sorting.mp4 (433 KB) workspaces-fal-sorting.mp4 Lorenz Ulrich, 2015-11-30 10:56
71973.patch (936 Bytes) 71973.patch Alexander Jahn, 2017-08-02 13:57

Related issues

Related to TYPO3 Core - Task #69967: Extract data overlay handling to common classClosed2015-09-19

Actions
Related to TYPO3 Core - Bug #54884: RootlineUtility does not consider foreign_sorting for relation fieldsClosedMarkus Klein2014-01-09

Actions
#1

Updated by Lorenz Ulrich over 5 years ago

I updated to 6.2.17 to see if #69967 solved the problem. It solved a part of the problem: Sorting files now works in the backend. But in the Workspace preview, the "to-be-published sorting" is not applied.

#2

Updated by Oliver Hader over 5 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Oliver Hader

How are the relations retrieved in the frontend preview (TypoScript FILES, levelmedia, etc.). It would be great if you could paste the accordant snipped here.
It seems, that the relations are stored correctly but fetching in the frontend scope (still) has problems.
Thanks in advance for your feedback!

#3

Updated by Lorenz Ulrich about 5 years ago

Thanks for your feedback, Oliver.

The files are normal content elements of type Filelinks so AFAIK it's TypoScript FILES / FilesContentObject.

#4

Updated by Viktor Livakivskyi almost 5 years ago

I confirm the same issue in TYPO3 7.6
Order of file relations is ok in BE, but isn't applied at FE.
Using css_styled_cointent, tried with "File links" and "Images" CEs.

Interesting part is, that sorting is wrong only in case, when editing already published (LIVE) CE record. If it is a new one (created within a Workspace), all the changed are visible in FE as well.

#5

Updated by Alexander Opitz over 4 years ago

IMHO this sorting issue was resolved in recent TYPO3 updates.
Can you please check again?

#6

Updated by Thorsten Kahler over 4 years ago

Alexander Opitz wrote:

IMHO this sorting issue was resolved in recent TYPO3 updates.

No, that issue still exists.

#7

Updated by Alexander Opitz over 4 years ago

  • Status changed from Needs Feedback to New
#8

Updated by Alexander Jahn almost 4 years ago

I found the same issue today.

The problem is caused by FileRepository::findByRelation selecting file_references and then doing a workspace overlay. The overlay changes the reference's sorting field.

The solution might be to reapply the ordering on all selected items.

I have attached a patch that should solve the issue.

Edit: my patch is against TYPO3 8.7.4

#9

Updated by bitfire it services almost 2 years ago

Maybe this is the same as #54884?

#10

Updated by Benni Mack almost 2 years ago

  • Related to Bug #54884: RootlineUtility does not consider foreign_sorting for relation fields added
#11

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714

#12

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714

#13

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714

#14

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61732

#15

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61733

#16

Updated by Benni Mack almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#17

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF