TYPO3 Core

Calling deprecated function in 7.6.10-dev

IconUtility::getSpriteIcon('flags-de');

is broken in 7.6. I get a red cross for that while the HTML output is

<span class="t3-icon t3-icon-status t3-icon-status-status t3-icon-status-icon-missing"> </span>

It could fall back to

/** @var \TYPO3\CMS\Core\Imaging\IconFactory $iconFactory */
$iconFactory = Typo3GeneralUtility::makeInstance('TYPO3\CMS\Core\Imaging\IconFactory');
$iconFactory->getIcon('flags-de', Icon::SIZE_SMALL);

Which gives me the HTML output

<span class="t3js-icon icon icon-size-small icon-state-default icon-flags-de" data-identifier="flags-de">
  <span class="icon-markup">
    <img src="/typo3/sysext/core/Resources/Public/Icons/Flags/SVG/DE.svg" height="16" width="16">
  </span>
</span>

So the suggested fix could be to let IconUtility::getSpriteIcon() call $iconFactory->getIcon().

That would result in SVG output (consistent with other SVG flags).

Note that 7.6.10-dev code documentation still suggests the use of IconUtility in respect to flags, e.g.

typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php Line 47:
The calling party should call
     * \TYPO3\CMS\Backend\Utility\IconUtility::getSpriteIcon(<flags-xx>) to get an HTML
     * which will represent the flag of this language.

Additionally, old css and .PNG flags and bugfix 68217 could be of use when used directly without using IconUtility::getSpriteIcon() or $iconFactory->getIcon() to make mitigate the breaking change.

Another option would be to implement issue 77048, which embeds all the SVG files into few css files. 77048 also allows to use simple CSS classes again while the same class names could be used as in 6.2, at least for a transition/deprecation concept.

If backported to 7.6, 77048 could even potentially mitigate the breaking change (which occured via 70477), still giving all the benefits of SVG, plus improving backend's performance in 7.6 and beyond.

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49161

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49161