Bug #79508

SelectIcon rendering does not fit in screen

Added by Georg Ringer over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2017-01-26
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
Stabilization Sprint

Description

Since the change of #79440 the rendering of select icons is not really nice anymore.
Instead of a table with fixed 12 cols divs should be used which can just float.

selecticons.png View (60.5 KB) Georg Ringer, 2017-01-26 19:49

after---.png View (13.2 KB) Josef Glatz, 2017-03-09 08:49

before--.png View (85.5 KB) Josef Glatz, 2017-03-09 08:49

before-7_6.png View (11.9 KB) Josef Glatz, 2017-03-09 08:49

selecticons170313-073909.png View (113 KB) Josef Glatz, 2017-03-13 07:40


Related issues

Related to TYPO3 Core - Story #69617: FormEngine bugs Accepted 2012-08-28
Related to TYPO3 Core - Feature #79440: FormEngine element level refactoring Closed 2017-01-24
Duplicated by TYPO3 Core - Bug #80189: Backend Layout Icons wrap not working properly Closed 2017-03-08

Associated revisions

Revision 447aff0c (diff)
Added by Georg Ringer over 2 years ago

[BUGFIX] Fix rendering of select icons

Use floating divs for the select icons instead of
a table with a fixed column count of 12.

Resolves: #79508
Releases: master
Change-Id: I4b4f485753ca33aa71d5c533b437e518da2096ed
Reviewed-on: https://review.typo3.org/51983
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Reviewed-by: Thomas Hohn <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Christian Kuhn over 2 years ago

Will ask benji if he can have a quick look at the html of selectIcons.

#2 Updated by Benni Mack over 2 years ago

  • Target version changed from 8.6 to 8 LTS

#3 Updated by Christian Kuhn over 2 years ago

  • Sprint Focus set to Stabilization Sprint

#4 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51983

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51983

#6 Updated by Josef Glatz over 2 years ago

Note about patchset 2

before

after


In TYPO3 7.6: a 1px border was around the tablerows

should we add that again?

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51983

#8 Updated by Josef Glatz over 2 years ago

Patch set 3 adds the known border around the iconset

#9 Updated by Georg Ringer over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF