Bug #81247

DatabaseRecordLinkBuilder: External pageTs not loaded

Added by Rainer Becker over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-05-17
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When I put my linkhandler pageTs configuration in an external file and linking, it wont be found when the link gets rendered (but its found when displaying the linkhandler with the linkhandler tabs). Putting the configuration in the page record solves the problem for me. (8.7.1)


Related issues

Related to TYPO3 Core - Bug #80883: Illegal string offset 'TCEMAIN.' in typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php line 34 Closed 2017-04-19
Related to TYPO3 Core - Bug #82662: TSFE getPagesTSconfig does not use included registered page TSconfig Closed 2017-10-03

History

#1 Updated by José Ricardo about 2 years ago

  • Related to Bug #80883: Illegal string offset 'TCEMAIN.' in typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php line 34 added

#2 Updated by Malte Koitka about 2 years ago

I can also confirm this. It seems that the processing of tsconfig_includes is missing in TypoScriptFrontendController::getPagesTSconfig().

#3 Updated by Paul Golmann about 2 years ago

Malte Koitka wrote:

I can also confirm this. It seems that the processing of tsconfig_includes is missing in TypoScriptFrontendController::getPagesTSconfig().

Tested in v8.7.2 I can also confirm that the PageTSConfig loaded in the frontend for the link handler is missing tsconfig_includes. A look into TypoScriptFrontendController::getPagesTSconfig() and BackendUtility::getPagesTSconfig() shows the missing parts. The code for TSFE seems outdated. In additional to a lack of support for tsconfig_includes it is using the TypoScriptParser instead of the TsConfigParser and is also missing the getPagesTSConfigPreInclude compared to the BackendUtility.

#4 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from New to Needs Feedback

I performed the following test:

Prerequisites

1) TYPO3 8.7.12
2) EXT:news 6.3.0
3) the news records are stored in a sysfolder with uid=9
4) I created two pages: one to list the news (uid=7) and one for the detail view of the news (uid=8)
5) I created a "sitepackage-like" extension EXT:bhsiteconf

Test Execution

1) I stored the TSConfig configuration in the file EXT:bhsiteconf/Configuration/TSConfig/Page/TCEMAIN.typoscript; the file is loaded via \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::registerPageTSConfigFile
2) The relevant part of the TSConfig for the linkhandler is:

TCEMAIN.linkHandler.news {
    handler = TYPO3\CMS\Recordlist\LinkHandler\RecordLinkHandler
    label = NEWS
    configuration {
        table = tx_news_domain_model_news
        storagePid = 9
    }
    scanBefore = page
}

3) The The TS Setup of the extension is loaded using \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addStaticFile; the setup.typoscript file just contains a line that loads all the .typoscript files inside a folder:

<INCLUDE_TYPOSCRIPT: source="DIR:EXT:bhsiteconf/Configuration/TypoScript/Setup/" extensions="typoscript">

4) I write on one of those files:

config.recordLinks.news {
    forceLink = 0
    typolink {
        parameter = 8
        additionalParams.data = field:uid
        additionalParams.wrap = &tx_news_pi1[news]=|&tx_news_pi1[controller]=News&tx_news_pi1[action]=detail
        useCacheHash = 1
    }
}

5) I created some news
6) On a page, I added a content element (e.g. Text); typed a title like "sample" and clicked on the link button to add a link to it

Results

- the link wizard popup has a "NEWS" tab; the news records can be selected as links
- the link is reported in the "link" field of the headline as "t3://record?identifier=news&uid=7"
- previewing the frontend, the link is rendered and works (goes to the correct detail news)

Do you think that this is sufficient to consider this issue resolved? Should a different test be performed? If it is so, could you add a step-by-step guide about how to reproduce the issue.

Thank you!

#5 Updated by Rainer Becker over 1 year ago

Your tests confirm that the original issue was solved - thank you!

#6 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Needs Feedback to Closed

Thank you very much for your feedback.

I'll close this one for now; if you think that this is the wrong decision or experience the issue again or that there is still work to do on this topic, please reopen it or open a new issue with a reference to this one.

Thank you and best regards

#7 Updated by Robert Vock over 1 year ago

  • Related to Bug #82662: TSFE getPagesTSconfig does not use included registered page TSconfig added

#8 Updated by Robert Vock over 1 year ago

It was fixed with #82662

Also available in: Atom PDF