Bug #83591
closedGraphicsMagick + [GFX][processor_effects] = '0' is set to '-1' just by entering the Install Tool
100%
Description
Whenever entering the Install Tool, the setting [GFX][processor_effects] is set to '-1'.
I started with the GraphicsMagick preset and altered the LocalConfiguration.php by hand, setting [GFX][processor_effects] to '0'. This works until I click again on the Install Tool module. Navigating within the Install Tool directly after changing the value, you have to re-enter the Install Tool completly.
I work-around this by setting the value in AdditionalConfiguration.php which takes precedence over LocalConfiguration.php, but ideally this should be fixed in the core.
Bug #81700 is probably related. I'm not sure if this happens with ImageMagick as well, because I only have access to GraphicsMagick in the setup where I encountered this.
Updated by S P over 6 years ago
Whoops, the unfinished sentence should read:
Navigating within the Install Tool directly after changing the value does not trigger the effect, you have to re-enter the Install Tool completly (which immediatly triggers it).
Updated by Stephan Großberndt over 6 years ago
- Related to Bug #81700: Images get sharpend even if [GFX][processor_effects] is set to -1 added
Updated by Guido S. over 6 years ago
It's not a bug, it's a feature :-)
typo3\sysext\install\Classes\Service\SilentConfigurationUpgradeService.php checks if GraphicsMagick is active, and return -1 for processor_effects for GM:
if ((string)$currentProcessorValue !== '') {
if ($currentProcessorMaskValue != 0) {
$changedValues['GFX/processor_allowTemporaryMasksAsPng'] = 0;
}
if ($currentProcessorValue === 'GraphicsMagick') {
if ($currentProcessorEffectsValue != -1) {
$changedValues['GFX/processor_effects'] = -1;
}
}
}
This could be a historic decision because sharpen might not always be available to GM. The code is also active in the current master.
My two cents: We can remove this check, see current gm doc: http://www.graphicsmagick.org/GraphicsMagick.html#details-sharpen If a gm version does not support sharpen, you can disable this manually at processor_effects.
Updated by Riccardo De Contardi about 6 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review about 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57319
Updated by Gerrit Code Review about 6 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57324
Updated by Gerrit Code Review about 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57319
Updated by Gerrit Code Review about 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57319
Updated by Gerrit Code Review about 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57339
Updated by Marc Willmann about 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1b869d7a21ba82b9edde21f7ff4be7019724bffa.
Updated by Gerrit Code Review about 6 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57391
Updated by Gerrit Code Review about 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57391
Updated by Gerrit Code Review about 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57391
Updated by Mathias Brodala about 6 years ago
- Related to Task #82768: Graphics API added
Updated by Gerrit Code Review about 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57391
Updated by Gerrit Code Review about 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57395
Updated by Mathias Brodala about 6 years ago
- Status changed from Under Review to Resolved
Applied in changeset 5d0fdb37c2a66c5c49e604a5b0f8449d0d2e846a.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed