Feature #86629

Implement LinkHandler for telephone numbers

Added by Rune Piper over 1 year ago. Updated 2 months ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2018-10-11
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

Currently the core supports 6 LinkHandlers:

'page'   => \TYPO3\CMS\Core\LinkHandling\PageLinkHandler::class,
'file'   => \TYPO3\CMS\Core\LinkHandling\FileLinkHandler::class,
'folder' => \TYPO3\CMS\Core\LinkHandling\FolderLinkHandler::class,
'url'    => \TYPO3\CMS\Core\LinkHandling\UrlLinkHandler::class,
'email'  => \TYPO3\CMS\Core\LinkHandling\EmailLinkHandler::class,
'record' => \TYPO3\CMS\Core\LinkHandling\RecordLinkHandler::class,

I suggest another LinkHandler for telephone numbers, similar to the email one.

Take a look at this extension for reference: https://github.com/monosize/typo3-ext-linkhandler-plus


Related issues

Related to TYPO3 Core - Bug #90004: Avoid showing telephone element for route link browser Closed 2019-12-22
Related to TYPO3 Core - Bug #89532: Blind options folder,tel in redirects Closed 2019-10-28
Related to TYPO3 Core - Bug #90771: InputLinkElement does not support telefphone links Closed 2020-03-17

Associated revisions

Revision d19ec279 (diff)
Added by Rune Piper over 1 year ago

[FEATURE] Add a telephone (tel:) link handler

The new link handler allows you to set links
in a new tab in the link browser to
phone numbers using the tel: protocol.

Resolves: #86629
Releases: master
Change-Id: I1a69fefbe16db9aaae51abfd80f154fa6aa8791a
Reviewed-on: https://review.typo3.org/58674
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Tested-by: TYPO3com <>
Reviewed-by: Jörg Bösche <>
Tested-by: Mona Muzaffar <>
Reviewed-by: Mona Muzaffar <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58674

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58674

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58674

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58674

#5 Updated by Rune Piper over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#7 Updated by Oliver Hader 5 months ago

  • Related to Bug #90004: Avoid showing telephone element for route link browser added

#8 Updated by Oliver Hader 5 months ago

  • Related to Bug #89532: Blind options folder,tel in redirects added

#9 Updated by Leonie Philine Bitto 2 months ago

  • Category set to Backend User Interface
  • Status changed from Closed to New
  • Target version set to next-patchlevel

The "inputLink" backend form element renderType was overlooked:

\TYPO3\CMS\Backend\Form\Element\InputLinkElement::getLinkExplanation() does not handle Telephone links and returns $data['text'] == 'not implemented type telephone'

This is the situation at TYPO3 10.3.

To reproduce:

1. Create a TCA field like:

        'link'               => [
            'exclude'        => true,
            'label'          => 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:header_link',
            'config'         => [
                'type'            => 'input',
                'renderType'      => 'inputLink',
                'size'            => 50,
                'max'             => 1024,
                'eval'            => 'trim,required',
                'autocomplete'    => true,
                'fieldControl'    => [
                    'linkPopup'   => [
                        'options' => [
                            'title'            => 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:header_link_formlabel',
                            'blindLinkFields'  => 'class, params, title',
                            'blindLinkOptions' => '',
                        ],
                    ],
                ],
                'softref'    => 'typolink',
            ],
        ],

2. Create a record with above defined field in the backend.

3. Open the link popup ("BrowseLinks"), choose "Telephone" and enter a phone number.

4. Click "Set link" to apply and close the dialog window.

Actual result:
The link preview field displays: "not implemented type telephone" as returned by \TYPO3\CMS\Backend\Form\Element\InputLinkElement::getLinkExplanation().

Expected result:
The link preview field renders a phone icon and the phone number (as works perfectly for mailto links.).

#10 Updated by Georg Ringer 2 months ago

  • Related to Bug #90771: InputLinkElement does not support telefphone links added

#11 Updated by Georg Ringer 2 months ago

  • Status changed from New to Closed

dear Leonie Philine Bitto,

I am closing this issue again and opend a new one #90771.

Also available in: Atom PDF