TYPO3 Core

Dear Ladies and Gentlemen,

I found a fix:

--- RecordsContentObject.php-2019-03-22-dax 2019-03-22 08:57:14.250440251 0100
++ RecordsContentObject.php 2019-03-22 11:54:13.442445523 0100
@ -95,9 +95,9 @
// Versioning preview
$this->getPageRepository()->versionOL($val['table'], $row);
// Language overlay
- if (is_array($row)) {
- $row = $this->getPageRepository()->getLanguageOverlay($val['table'], $row);
- }
// if (is_array($row)) {
// $row = $this->getPageRepository()->getLanguageOverlay($val['table'], $row);
// }
}
// Might be unset during the overlay process
if (is_array($row)) {

The LanguageOverlay check in this case is unnecessary as the records are inserted by uid and the language check is also incompatible with 8LTS.
However I am currently testing in my upgrade testing site clone.

Have a nice weekend and best regards,

Patrick

Hello Patrick,

I now rechecked this with various v8 installations we have:

On L=0
- Only L=-1 or L=0 records are shown, if you have selected other translated records, they are not rendered.

On L=2 (greek e.g.)
- If you reference a content element with L=0, then the translation gets shown
- If you reference a content element with language that does not match the current language (e.g. L=3) then it does NOT show up.

So, the current 9.5.6 behaviour (see my previous) comment allows this setup as well.

Dear Benni,

In my opinion "Insert Records" does not need a sys_language_uid check.
If I want to insert a record intentionally of a different language, that check blocks it and it removes the option to do so for whatever reason.

But here an example: Assume I create an Address element which is in Language 0 in Latin characters and in Language 27 in Cyrillic Characters.
Now I have a site with English (sys_language_uid = 0), Ukrainian (sys_language_uid = 27) and Russian (sys_language_uid = 22) and then for my lazyness, I refer to the Latin version of the content element in the whole english site by "insert records", but for Ukrainian and Russian I use the same cyrillic version which is the Ukrainian version of that address.

For me the language check is unnecessary, as it gives no benefit at all.
Do you see a need to protect people from inserting records of another language ? Do you know a case ?

Alternatively, a configuration option could be introduced:
e.g. something like: insert_records.strict_language_check

For now I will keep my core patched to remove that check.

Best regards,

Patrick

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098

Dear Patrick,

as long as this patch is not merged, you can use https://github.com/georgringer/insert-records-overlaymode to achieve the same output

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64098