Bug #88344
closedHMENU directory incompatible with free mode
100%
Description
When TYPO3 is set to run in Free mode, HMENU of type directory stop working for localized pages.
The query to fetch the subpages uses exec_getQuery from the ContentObjectRenderer, thus \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::getLanguageRestriction is applied and the pages with the required languages are fetched directly.
In theory, this behaviour is correct, since it returns what it was configured for for, but pages is a special case, where at some points the overlay information from _PAGES_OVERLAY and _PAGES_OVERLAY_LANGUAGE is checked, as well as the page id differs to what the router returns.
See \TYPO3\CMS\Frontend\Page\PageRepository::isPageSuitableForLanguage for the mentioned checks.
It seems like replacing the exec_getQuery with the already existing API does the job, see \TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject::prepareMenuItemsForDirectoryMenu
// Get sub-pages: // $statement = $this->parent_cObj->exec_getQuery('pages', ['pidInList' => $id, 'orderBy' => $sortingField]); // while ($row = $statement->fetch()) { $rows = $this->sys_page->getMenu($id, '*', $sortingField); foreach ($rows as $row) {
Updated by Christian Eßl almost 5 years ago
- Related to Bug #89368: Active page added
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62527
Updated by Michael Binder over 4 years ago
I had the same problem and your solution works well, thank you for that.
I also tested it with the other fallback types and the menu is always displayed correctly. So I made a patch and sent it to Gerrit.
Updated by Anonymous over 4 years ago
- Related to Bug #89038: HMENUs special "directory" does not work properly with sites fallbackType "free" added
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62466
Updated by Michael Binder over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 47e63fc33c7dd45111465d833216eb474f224b9e.
Updated by Georg Ringer over 4 years ago
- Related to Bug #89989: Since v9.5.12 extendToSubpages has no effect for subpages in menus added
Updated by Benni Mack over 4 years ago
- Related to Bug #88685: With "Hide default translation of page" no link for alternate language is generated added
Updated by Benni Mack over 4 years ago
- Related to Bug #85987: Menus doesn't respect language settings and show non translated pages added
Updated by Georg Ringer over 4 years ago
- Related to Bug #88987: Menu Generation Fails on Translated Websites added
Updated by Georg Ringer over 4 years ago
- Related to Bug #90971: HMENU regression in 9.5.12 added
Updated by Alexander Bohn over 3 years ago
- Related to Bug #93014: translation for navigation is incomplete in free mode since v9.5.16 added