Project

General

Profile

Actions

Task #94057

closed

PHP 8.0 Acceptance Tests

Added by Larry Garfield almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2021-05-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
Complexity:
Sprint Focus:

Description

Resolve any outstanding acceptance test issues with PHP 8.0. Or at least any we can find.


Files


Related issues 8 (0 open8 closed)

Related to TYPO3 Core - Epic #93631: PHP 8 CompatClosed2021-03-02

Actions
Related to TYPO3 Core - Bug #94154: TypeError for missing transOrigPointerField fieldClosedDaniel Siepmann2021-05-18

Actions
Related to TYPO3 Core - Bug #94248: #94057 breaks site configuration in 11.3Closed2021-06-01

Actions
Related to TYPO3 Core - Bug #94301: Clipboard in recordlist can't longer be turned offClosedOliver Bartsch2021-06-10

Actions
Related to TYPO3 Core - Bug #94329: Adapt to error_reporting level with PHP 8 STFU operatorClosed2021-06-12

Actions
Related to TYPO3 Core - Bug #94333: Remaining PHP8 fixes for acceptance testsClosed2021-06-14

Actions
Related to TYPO3 Core - Bug #94949: Re-enable reset of excluded records in EXT:impexpClosed2021-08-21

Actions
Related to TYPO3 Core - Bug #95187: Setting `offlineMode` added to settings array in extbaseClosedTorben Hansen2021-09-11

Actions
Actions #1

Updated by Larry Garfield almost 3 years ago

Actions #2

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #7

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #8

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #9

Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #10

Updated by Gerrit Code Review almost 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #11

Updated by Gerrit Code Review almost 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #12

Updated by Gerrit Code Review almost 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #13

Updated by Gerrit Code Review almost 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #14

Updated by Gerrit Code Review almost 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #15

Updated by Gerrit Code Review almost 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #16

Updated by Gerrit Code Review almost 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #17

Updated by Gerrit Code Review almost 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #18

Updated by Gerrit Code Review almost 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #19

Updated by Gerrit Code Review almost 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #20

Updated by Gerrit Code Review almost 3 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #21

Updated by Gerrit Code Review almost 3 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #22

Updated by Gerrit Code Review almost 3 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #23

Updated by Gerrit Code Review almost 3 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #24

Updated by Gerrit Code Review almost 3 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012

Actions #25

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #26

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #27

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #28

Updated by Larry Garfield almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #29

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #30

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #31

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #32

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #33

Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #34

Updated by Gerrit Code Review almost 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #35

Updated by Oliver Bartsch almost 3 years ago

  • Related to Bug #94154: TypeError for missing transOrigPointerField field added
Actions #36

Updated by Gerrit Code Review almost 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #37

Updated by Gerrit Code Review almost 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #38

Updated by Gerrit Code Review almost 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #39

Updated by Gerrit Code Review almost 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69152

Actions #40

Updated by Larry Garfield almost 3 years ago

  • Status changed from Under Review to Resolved
Actions #41

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #42

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #43

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #44

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #45

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #46

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #47

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #48

Updated by Gerrit Code Review almost 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Actions #49

Updated by Larry Garfield almost 3 years ago

  • Status changed from Under Review to Resolved
Actions #50

Updated by André Buchmann almost 3 years ago

Hey, with the current 11.3-dev branch the Site Configuration Module doesn't load the yaml file correctly (see screenshot).
In 11.2.0 it's working. I tracked the issue down to the changes applied with this merge: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69255

Currently running with php 7.4 an introduction package. Tried also with php 8.0 which shows the same result and a warning.

php 8.0 warning:

PHP Warning
Core: Error handler (BE): PHP Warning: Undefined array key "uid" in /var/www/html/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php line 73

Actions #51

Updated by André Buchmann almost 3 years ago

  • Related to Bug #94248: #94057 breaks site configuration in 11.3 added
Actions #52

Updated by Larry Garfield almost 3 years ago

André Schließer: Can you clarify how you got to that error? What path are you on for it?

I am trying to track down the last remaining acceptance test fails, but cannot replicate them. According to the `failed` file output, there are still 18 tests that do not pass:

Acceptance/Backend/FileList/FileMetaDataCest.php:metaDataCanBeEdited
Acceptance/Backend/FormEngine/FalMetadataCest.php:checkIfUpdatedFileMetadataIsUpdatedInContent
Acceptance/Backend/FormEngine/NullPlaceholderCest.php:checkIfDeactivatingNullCheckboxesMarksAsChanged
Acceptance/Backend/Topbar/UsernameOnAvatarCest.php:usernameIsShown
Acceptance/Backend/BackendUser/ListUserCest.php:filterUsersByUsername
Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php:checkUninstallingAndInstallingAnExtension
Acceptance/Backend/General/ModuleMenuCest.php:selectingAModuleDoesHighlightIt
Acceptance/Backend/Login/BackendLoginCest.php:loginWorksAsEditorUser
Acceptance/Backend/Scheduler/TasksCest.php:createASchedulerTask
Acceptance/Backend/Scheduler/TasksCest.php:canCreateNewTaskGroupFromEditForm
Acceptance/Backend/Topbar/BookmarkCest.php:checkThatBookmarkListIsInitiallyEmpty
Acceptance/Backend/Topbar/ModuleMenuButtonCest.php:checkModelMenuButtonFromBigToSmallScreen
Acceptance/Backend/Topbar/ModuleMenuButtonCest.php:checkModelMenuButtonFromSmallToBigScreen
Acceptance/Backend/Topbar/NavigationComponentTreeCest.php:checkTreeExpandsAndCollapseByPageModule
Acceptance/Backend/Topbar/NavigationComponentTreeCest.php:checkTreeExpandsAndCollapseByFileModule
Acceptance/Backend/Topbar/SearchCest.php:searchAndTestIfAutocompletionWorks
Acceptance/Backend/Topbar/SearchCest.php:searchForFancyTextAndCheckEmptyResultInfo
Acceptance/Backend/Topbar/SearchCest.php:checkIfTheShowAllLinkPointsToTheListViewWithSearchResults

However, I've spot checked some of them manually and the test procedure works when I do it myself. The errors in the test output say various responses are returning 500 errors, but I cannot get the same result. I am not sure how to track that down, therefore. Any suggestions on how to replicate them or where the issue could be are welcome.

Actions #53

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393

Actions #54

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393

Actions #55

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393

Actions #56

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393

Actions #57

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393

Actions #58

Updated by Larry Garfield almost 3 years ago

  • Status changed from Under Review to Resolved
Actions #59

Updated by Oliver Bartsch almost 3 years ago

  • Related to Bug #94301: Clipboard in recordlist can't longer be turned off added
Actions #60

Updated by Christian Kuhn almost 3 years ago

  • Related to Bug #94329: Adapt to error_reporting level with PHP 8 STFU operator added
Actions #61

Updated by Christian Kuhn almost 3 years ago

  • Related to Bug #94333: Remaining PHP8 fixes for acceptance tests added
Actions #62

Updated by Alexander Nitsche over 2 years ago

  • Related to Bug #94949: Re-enable reset of excluded records in EXT:impexp added
Actions #63

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions #64

Updated by Christian Kuhn over 2 years ago

  • Related to Bug #95187: Setting `offlineMode` added to settings array in extbase added
Actions

Also available in: Atom PDF