Project

General

Profile

Actions

Bug #98045

open

DateAspect->getTimezone (almost) never returns the correct value

Added by Jan Delius over 1 year ago. Updated 22 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2022-07-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

On the way the DateTimeAspect is initiated, there is never an evaluation of the current time zone. Thus the aspect always returns only the time zone "+00:00". Also the ISO date is always given in UTC instead of the currently set server time zone.

An example of this is given in the method TYPO3\CMS\Frontend\Http\Application::initializeContext():

$this->context->setAspect('date', new DateTimeAspect(new \DateTimeImmutable('@' . $GLOBALS['EXEC_TIME'])));

A proof-of-concept code that makes the aspect return the correct values:

$dateTime = new \DateTime('@' . $GLOBALS['EXEC_TIME']);
$dateTime->setTimezone(new \DateTimeZone(date_default_timezone_get()));
$this->context->setAspect('date', new DateTimeAspect(\DateTimeImmutable::createFromMutable($dateTime)));

This aspect is created in several places in the TYPO3 core. The value of date_default_timezone_get() is already defined beforehand by TYPO3 (if required) and should thus be able to be taken.

Apparently this bug has been present since the existence of the aspects until the current branch of the 12 version.


Related issues 1 (1 open0 closed)

Has duplicate TYPO3 Core - Bug #99627: Context:class don't detect timezone correctlyUnder Review2023-01-19

Actions
Actions #1

Updated by Jan Delius over 1 year ago

  • Description updated (diff)
Actions #2

Updated by Andreas Kienast over 1 year ago

  • Sprint Focus set to On Location Sprint
Actions #3

Updated by Oliver Hader over 1 year ago

  • Sprint Focus deleted (On Location Sprint)
Actions #4

Updated by Felix Nagel about 1 year ago

Can confirm this issue for TYPO3 11.5.21.

Actions #5

Updated by Jan Delius 11 months ago

  • Has duplicate Bug #99627: Context:class don't detect timezone correctly added
Actions #6

Updated by Andreas Wolf 3 months ago

  • Status changed from New to In Progress
  • Assignee set to Andreas Wolf
Actions #7

Updated by Gerrit Code Review 3 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81915

Actions #8

Updated by Gerrit Code Review 22 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81915

Actions #9

Updated by Gerrit Code Review 22 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81915

Actions

Also available in: Atom PDF