Bug #24641
closed
icon deleted page into workspace
100%
Description
When we work in a workspace draft and we try to delete a page, the icon of this page doesn’t change: it doesn’t appear the page with the icon of a removed page.
(issue imported from #M17117)
Files
Updated by Francois Suter over 13 years ago
I can confirm this issue. There's a double problem actually:
1) the "deleted" overlay is not considered in the priority list of overlays
2) the "deleted" versioning status is not considered to set the type of overlay that should be used.
I opened a separate bug report for 1.
Updated by Francois Suter over 13 years ago
The attached patch makes it work again, in conjunction with the patch from 0017815.
However this is not a clean solution as we are trying to separate all version-related stuff from the Core. Maybe it could be ok for 4.5, but for 4.6 we should find another solution, probably using a hook.
Updated by Francois Suter over 13 years ago
- Project changed from TYPO3 Core to 624
- Target version deleted (
0)
To solve this bug the version extension could use the hook proposed in #25765, so that deleted records are displayed with the proper overlay.
Updated by Francois Suter over 13 years ago
- File 24641.diff 24641.diff added
The hook proposal mentioned previously has been submitted for current TYPO3 trunk (4.6). The attached patch uses the hook and overrides the "deleted" status when t3ver_state = 2.
I'll officially submit this patch when the corresponding changes will have been made in Core.
Updated by Mr. Hudson about 13 years ago
Patch set 1 of change I2c07e3ceae70aa971e1086dd1f902a960b862d09 has been pushed to the review server.
It is available at http://review.typo3.org/1660
Updated by Francois Suter about 13 years ago
- move to a workspace
- move Web > List view
- delete some record (content element, news, whatever)
- the record shows no sign of being deleted
- apply patch for #25215 (https://review.typo3.org/#change,1459)
- apply patch for this issue
- reload the list view => the deleted record should have a trash can overlay on its icon
NOTE: the new hook in the Core has been proposed for inclusion in 4.5 too (and should be accepted given the discussion on hook policy for LTS), so this patch should be applied to 4.5 and trunk too.
Updated by Susanne Moog about 13 years ago
- Status changed from Accepted to Under Review
Updated by Mr. Hudson about 13 years ago
Patch set 2 of change I2c07e3ceae70aa971e1086dd1f902a960b862d09 has been pushed to the review server.
It is available at http://review.typo3.org/1660
Updated by Mr. Hudson about 13 years ago
Patch set 3 of change I2c07e3ceae70aa971e1086dd1f902a960b862d09 has been pushed to the review server.
It is available at http://review.typo3.org/1660
Updated by Mr. Hudson about 13 years ago
Patch set 1 of change I63793da2450dbf5113218441713a5edb79e6f21d has been pushed to the review server.
It is available at http://review.typo3.org/1920
Updated by Mr. Hudson about 13 years ago
Patch set 2 of change I63793da2450dbf5113218441713a5edb79e6f21d has been pushed to the review server.
It is available at http://review.typo3.org/1920
Updated by Mr. Hudson about 13 years ago
Patch set 3 of change I63793da2450dbf5113218441713a5edb79e6f21d has been pushed to the review server.
It is available at http://review.typo3.org/1920
Updated by Mr. Hudson about 13 years ago
Patch set 4 of change I2c07e3ceae70aa971e1086dd1f902a960b862d09 has been pushed to the review server.
It is available at http://review.typo3.org/1660
Updated by Oliver Hader about 13 years ago
- Status changed from Under Review to Resolved
- Assignee set to Oliver Hader
- Target version set to 4.5.3
- % Done changed from 0 to 100
Submitted to
TYPO3 4.5.3
TYPO3 4.6-alpha1
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
- Target version deleted (
4.5.3)
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed