Bug #24641: icon deleted page into workspace - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (2)

Mauro Lorenzutti
Ufficio della comunicazione elettronica

Actions

Copy link

Bug #24641

closed

icon deleted page into workspace

Added by Ufficio della comunicazione elettronica over 13 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Oliver Hader

Category:

Workspaces

Target version:

Start date:

2011-01-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.4

PHP Version:

5.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When we work in a workspace draft and we try to delete a page, the icon of this page doesn’t change: it doesn’t appear the page with the icon of a removed page.

(issue imported from #M17117)

Files

Download all files

bug-icon-deleted_page-workspace_draft.pdf (172 KB) bug-icon-deleted_page-workspace_draft.pdf		Administrator Admin, 2011-01-18 15:29
17117.diff (458 Bytes) 17117.diff		Administrator Admin, 2011-03-03 21:11
24641.diff (2.7 KB) 24641.diff		Francois Suter, 2011-04-05 15:25

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #25215: Deleted overlay type is missing from overlay priorities list

Closed

Francois Suter

2011-03-01

Actions

Related to TYPO3 Core - Feature #25765: Add hook when choosing icon overlays

Closed

Francois Suter

2011-04-05

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Francois Suter over 13 years ago

I can confirm this issue. There's a double problem actually:

1) the "deleted" overlay is not considered in the priority list of overlays
2) the "deleted" versioning status is not considered to set the type of overlay that should be used.

I opened a separate bug report for 1.

Actions

Copy link

Updated by Francois Suter over 13 years ago

The attached patch makes it work again, in conjunction with the patch from 0017815.

However this is not a clean solution as we are trying to separate all version-related stuff from the Core. Maybe it could be ok for 4.5, but for 4.6 we should find another solution, probably using a hook.

Actions

Copy link

Updated by Francois Suter over 13 years ago

Project changed from TYPO3 Core to 624
Target version deleted (0)

To solve this bug the version extension could use the hook proposed in #25765, so that deleted records are displayed with the proper overlay.

Actions

Copy link

Updated by Francois Suter over 13 years ago

File 24641.diff 24641.diff added

The hook proposal mentioned previously has been submitted for current TYPO3 trunk (4.6). The attached patch uses the hook and overrides the "deleted" status when t3ver_state = 2.

I'll officially submit this patch when the corresponding changes will have been made in Core.

Actions

Copy link

Updated by Susanne Moog over 13 years ago

Status changed from New to Accepted

Actions

Copy link

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I2c07e3ceae70aa971e1086dd1f902a960b862d09 has been pushed to the review server.
It is available at http://review.typo3.org/1660

Actions

Copy link

Updated by Francois Suter about 13 years ago

How to test:

move to a workspace
move Web > List view
delete some record (content element, news, whatever)
the record shows no sign of being deleted
apply patch for #25215 (https://review.typo3.org/#change,1459)
apply patch for this issue
reload the list view => the deleted record should have a trash can overlay on its icon

NOTE: the new hook in the Core has been proposed for inclusion in 4.5 too (and should be accepted given the discussion on hook policy for LTS), so this patch should be applied to 4.5 and trunk too.

Actions

Copy link