TYPO3 Core

Hey,

how about

if ($GLOBALS['TSFE'] && $GLOBALS['TSFE']->sys_page) {
...
}

?

Your version works, too. But I don't know if this is the more better/best version.

I disagree.
Benni's version will cause a warning when sys_page does not exist.
Please stick to thorough checking with isset().

I checked and the condition is built way different in 4.6 and 4.7 -> so I pushed the patch only for 4.5

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7043

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7043

Patch set 4 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7043

Patch set 5 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7043

i found that this change i causing fatal errors.

(i checked (and another user found it , too) with yag extension
see http://forge.typo3.org/issues/36487 for full error report

the problem is

    function versionOL(&$row) {
        if (TYPO3_MODE === 'FE') { // Frontend:
            $GLOBALS['TSFE']->sys_page->versionOL('sys_template', $row);
        } else { // Backend:
            t3lib_BEfunc::workspaceOL('sys_template', $row);
        }
    }

which i have to revert to:

    function versionOL(&$row) {
        if (is_object($GLOBALS['TSFE'])) { // Frontend:
            $GLOBALS['TSFE']->sys_page->versionOL('sys_template', $row);
        } else { // Backend:
            t3lib_BEfunc::workspaceOL('sys_template', $row);
        }
    }

(i tried to XCLASS versionOL with the working one, but it seems not possible.. old versionOL() is always called :(

what do you think?

sorry.. i think the problem is somewhere else..

versionOL gets called from t3lib_TStemplate->runThroughTemplates( ) but the sys_page is not fully instantiated...
the problem seems to be in pt_extbase

sorry for this false alarm

Hey all,

the comitted changed cause a Fatal error in the frontend if you use an eID and you work with the tstemplate class.
Why? It is quite easy. eID has the TYPO3_MODE FE but has no full blown up Frontend (e.g. $GLOBALS['TSFE'] / $GLOBALS['TSFE']->sys_page).

In our case we create via direct_mail api new mailings via an eid.
Direct mail calls this method to get the correct charset for this page.
So, with the new patch we got

Fatal error: Call to a member function versionOL() on a non-object in /var/www/dasgastroportal.dus.wmdb.de/typo3_src-4.5.15/t3lib/class.t3lib_tstemplate.php 
on line 753

In my opinion, this is a regression.

I will provide a patch.
See Bug #36981 "Regression of "better condition in versionOL of t3lib_tstemplate" (#31139)" for more information.