Project

General

Profile

Actions
Copy link

Feature #32543

closed

Some improvements for notification mail - new marker, list for multiple elements

Added by Sonja Schubert almost 13 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
7.5
Start date:
2011-12-14
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It would be nice to have some improvements for the workspace notification mails sent by version extension.

  • Nice list of elements in email if multiple elements were sent to next stage in one run
  • new marker ELEMENT_NUMBER so numerable the list of elements
  • new pageTsConfig option cropPathTitlesAfter to crop titles in email after number of chars

I attached the modified t3x of the version extension with a tested solution. I know that it is not nice to just attach the t3x and do not create patches. I am very sorry but I have no time this week to create these patches, but I will do this later.

Nevertheless some feedback if you like these features in general would be nice.

Files

Download all files
T3X_version-54_5_1-z-201112141516.t3x (91.2 KB) T3X_version-54_5_1-z-201112141516.t3x Sonja Schubert, 2011-12-14 15:17
T3X_version_mailfix-0_0_0-z-201202271418.t3x (10.6 KB) T3X_version_mailfix-0_0_0-z-201202271418.t3x Bart Dubelaar, 2012-02-27 14:26
Actions
Copy link
 #1

Updated by Tolleiv Nietsch almost 13 years ago

  • Status changed from New to Accepted

Sounds good... I'll try to bring up the patch for it to Gerrit for you.

Actions
Copy link
 #2

Updated by Tolleiv Nietsch almost 13 years ago

  • Assignee set to Tolleiv Nietsch
  • Target version set to 4.7.0
Actions
Copy link
 #3

Updated by Bart Dubelaar over 12 years ago

It seems that right now things only just accidentally go well when changing the stage of mutliple records:

In tx_version_tcemain:
When multiple records are selected, $elementName is formatted like this: "pages:100, pages:101, pages:102" etc..
So this line:
list($elementTable, $elementUid) = explode(':', $elementName);
Creates an $elementUid: "100, pages:101, pages:102"
Luckily then comes this line:
$elementUid = intval($elementUid);

I always wondered why the ###ELEMENT_NAME### held multiple records and all other markers didn't :-)

Actions
Copy link
 #4

Updated by Bart Dubelaar over 12 years ago

Hi Sonja,

I have moved your changes to a separately installable extension using XCLASS.

I have also improved your fix on a number of points:
  • Merged your code for multiple records with the existing code
  • Also fixed the behavior of the old markers
  • Made it compatible with both 4.5 and 4.6

As in your fix, this extension also includes this patch: https://review.typo3.org/#change,4519

This fix should be fully compatible with all old style markers and the old TSConfig options. I haven't fully tested all scenarios however.

Tolleiv, I could make a patch out of this and push it to Gerrit. Would that be a good idea, or would you rather have a look at it yourself?

Actions
Copy link
 #5

Updated by Steffen Ritter over 12 years ago

  • Target version deleted (4.7.0)
Actions
Copy link
 #6

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13346

Actions
Copy link
 #7

Updated by Bart Dubelaar over 12 years ago

I have created a proper patch for 6.0. I have submitted it as a feature, even though I think the behavior is actually broken in earlier versions too. But let's first get this patch into 6.0 and then see what can be backported. Patch for issue #26615 is committed in a separate patch.

Actions
Copy link
 #8

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13346

Actions
Copy link
 #9

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21105

Actions
Copy link
 #10

Updated by Michael Stucki almost 11 years ago

  • Category changed from New Features to Workspaces
Actions
Copy link
 #11

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions
Copy link
 #12

Updated by Wouter Wolters almost 10 years ago

  • Status changed from Under Review to Needs Feedback

Hi,

as this issue is very old. Is this feature missing in newer versions of TYPO3 CMS (6.2.9)?
If yes, can you provide a newer patch against master by using Gerrit? http://wiki.typo3.org/CWT

Actions
Copy link
 #13

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.5
Actions
Copy link
 #14

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Tolleiv Nietsch)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions
Copy link

Also available in: Atom PDF