Bug #39052
closedSend sane HTTP response in showpic on error
100%
Description
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Updated by Gerrit Code Review about 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12867
Updated by Christian Kuhn about 12 years ago
Example:
http://www.domain.foo/?eID=tx_cms_showpic&file=uploads%2Ftx_foo%2Faoeu.jpg&md5=7ec23ea567813281234569acb0e24347adfb8645¶meters0=YoeuntzOjU6IndpZHRoIjtzOjQ6Ijc3MG0iO3M6NzoiYm9keVRhZyI7czo2ODoi¶meters1=PGJvZHkgbGVmdG1hcmdpbj0iMCIgdG9wbWFyZ2lIwIiBtYXJnaW53aWR0aD0i¶meters2=MCIgbWFyZ2luaGVpZ2h0PSIwIj4iO3M6NDoid3I7czozNToiPGEgaHJlZj0i¶meters3=amF2YXNjcmlwjbG9zZSgpOyI%2BfDwvYT4iO30%3D
Will result in a 410 after the patch, and was an exception before.
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12915
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12917
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12919
Updated by Christian Kuhn about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0f83ce445cade0d3ec7b8c74f1282775769ffa65.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13198
Updated by Christian Kuhn about 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset d85d3b6fa9c142665a4703c883bfe14a8b16ecc8.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13305
Updated by Wouter Wolters almost 12 years ago
Please close this issue. All affected branches are up to date.
Updated by Stefan Galinski almost 12 years ago
- Status changed from Under Review to Closed