Project

General

Profile

Actions

Bug #39290

closed

Epic #65814: Make Indexed search extbase plugin shine

indexed_search pi2 (extbase/fluid plugin): Result titles are double-htmlspecialchared

Added by Andreas Kießling almost 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Indexed Search
Target version:
Start date:
2012-07-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

All links that are generated through Tx_IndexedSearch_Controller_SearchController->linkPage are passed through htmlspecialchars

return '<a href="' . htmlspecialchars($uri) . '"' . $target . '>' . htmlspecialchars($linkText) . '</a>';

But the $linkText is already prepared from the calling methods (because they e.g. generate some links on their own and so need to escape the title).
So the resulting HTML will be like this if there is an & in the page title:

News &amp;amp; Events

Tested on TYPO3 4.7.2

Actions #1

Updated by unkonsorten no-lastname-given about 11 years ago

Seems to be a general problem, also applies to marker based pi class. Verified for TYPO3 v 4.5-4.7
Occurs if plugin.tx_indexedsearch.search.detect_sys_domain_records is set. RealUrl doesn't work in this case, either even when creating links to pages on same domain.

Actions #2

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 7.5
  • Is Regression set to No
Actions #3

Updated by Tymoteusz Motylewski over 9 years ago

  • Parent task set to #65814
Actions #4

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7.4 (Backend)
  • Sprint Focus set to On Location Sprint
Actions #5

Updated by Wouter Wolters about 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Wouter Wolters
Actions #6

Updated by Gerrit Code Review about 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41599

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41599

Actions #8

Updated by Gordon Brüggemann about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41631

Actions #10

Updated by Gordon Brüggemann about 9 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Anja Leichsenring over 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #12

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF