Bug #39290
closed
Epic #65814: Make Indexed search extbase plugin shine
indexed_search pi2 (extbase/fluid plugin): Result titles are double-htmlspecialchared
100%
Description
All links that are generated through Tx_IndexedSearch_Controller_SearchController->linkPage are passed through htmlspecialchars
return '<a href="' . htmlspecialchars($uri) . '"' . $target . '>' . htmlspecialchars($linkText) . '</a>';
But the $linkText is already prepared from the calling methods (because they e.g. generate some links on their own and so need to escape the title).
So the resulting HTML will be like this if there is an & in the page title:
News &amp; Events
Tested on TYPO3 4.7.2
Updated by unkonsorten no-lastname-given over 11 years ago
Seems to be a general problem, also applies to marker based pi class. Verified for TYPO3 v 4.5-4.7
Occurs if plugin.tx_indexedsearch.search.detect_sys_domain_records is set. RealUrl doesn't work in this case, either even when creating links to pages on same domain.
Updated by Mathias Schreiber almost 10 years ago
- Target version set to 7.5
- Is Regression set to No
Updated by
Updated by Benni Mack over 9 years ago
- Target version changed from 7.5 to 7.4 (Backend)
- Sprint Focus set to On Location Sprint
Updated by Wouter Wolters over 9 years ago
- Status changed from New to In Progress
- Assignee set to Wouter Wolters
Updated by Gerrit Code Review over 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41599
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41599
Updated by Gordon Brüggemann over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 73608b22d3b1947151e02af00181674318638db8.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41631
Updated by Gordon Brüggemann over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset f2c8adac508b5b86a9d8d94d2ff047204533aea6.
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed