Bug #44470

Content elements in wrong column in page module

Added by Oliver Hader over 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2013-01-13
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If working on workspaces, it might happen that content elements just appear in the wrong column.
The reason is, that live(!) content elements are selected using a specific column value and then are overlays by workspace data.
If the column value has been modified in a workspace, this is currently just ignored during rendering.


Subtasks

Bug #44481: Check for new content element button uses old query objectClosedJigal van Hemert


Related issues

Related to TYPO3 Core - Bug #43430: Drag and Drop of content elements does not work Closed 2012-11-29
Related to TYPO3 Core - Bug #32967: Backend workspace copy/cut paste column content fails on publish Closed 2012-01-04
Related to TYPO3 Core - Bug #39983: Change colPos of content element in draft workspace Closed 2012-08-20
Related to TYPO3 Core - Bug #48939: Moving a content down moves it in another column Closed 2013-06-07
Precedes TYPO3 Core - Bug #47529: Regression in 4.7.11rc1: Invalid argument supplied for foreach() in class.tx_cms_layout.php line 404 Closed 2013-04-24

Associated revisions

Revision 047b6391 (diff)
Added by Oliver Hader over 6 years ago

[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I9eccc2ff5b7220544cd28ee6de8f55453c04a5d1
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17468
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 2abebe67 (diff)
Added by Oliver Hader over 6 years ago

[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I6669ea096d93269591727b20d92ef5250898900f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17496
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision f6d0567b (diff)
Added by Jigal van Hemert over 6 years ago

[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I148ca1b023226f2f99417b3baf238b72346e721f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17497
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Revision 1da948f9 (diff)
Added by Jigal van Hemert over 6 years ago

[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I148ca1b023226f2f99417b3baf238b72346e721f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17637
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

History

#1 Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17468

#2 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17468

#3 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17496

#4 Updated by Oliver Hader over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17497

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17637

#7 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/17638

#8 Updated by Jigal van Hemert over 6 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Oliver Hader over 6 years ago

Patch for TYPO3_4-6 has been dropped due to EOL

#10 Updated by Thorsten Kahler almost 6 years ago

  • Is Regression set to No

The solution causes an issue with the sorting buttons in page module because the colPos is ignored when attaching the sorting information in method PageLayoutView::getResult(). (see #48939 and related)

I suggest to revert the patch and use #32967 and #39983 instead.

#11 Updated by Jigal van Hemert almost 6 years ago

@Thorsten : the patches you mention do not solve this issue, nor do they solve the problem with the sorting buttons. This particular patch solved the problem that the content elements from the live workspace were first retrieved for each column and after that the workspace overlay was applied. If the column was moved to another column in the workspace it was displayed in the column where it was in the live workspace. This patch solves that by first retrieving the content elements from all columns, applying the workspace overlay and then distribute them to the columns.
The problem in getResult is that it was designed for use in a single column. The solution in https://review.typo3.org/25001 may not be perfect yet, but it will move the handling of the sorting links data to the right place.

#12 Updated by Thorsten Kahler almost 6 years ago

Jigal van Hemert wrote:

This particular patch solved the problem that the content elements from the live workspace were first retrieved for each column and after that the workspace overlay was applied. If the column was moved to another column in the workspace it was displayed in the column where it was in the live workspace. This patch solves that by first retrieving the content elements from all columns, applying the workspace overlay and then distribute them to the columns.

If move placeholders are created when content elements are moved between columns the original code of PageLayoutView works flawless because
  • placeholder records are fetched in the right column
  • moved records are detected when applying the WS overlay

If changing the colPos is handled as move operation this doesn't only solve the BE display issue #44470 but also fixes FE preview.

The problem in getResult is that it was designed for use in a single column. The solution in https://review.typo3.org/25001 may not be perfect yet, but it will move the handling of the sorting links data to the right place.

The (IMO) "perfect" solution would be to use move placeholders consistently. Then there would be no problem with getResult().

Please try to change the column via drag-n-drop and via BE form to see the difference: drag-n-drop already creates a move placeholder.

#13 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF