Project

General

Profile

Actions

Bug #51189

closed

Remove non-needed Url parameter for standard search

Added by Thomas Skierlo over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
Start date:
2013-08-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently (6.1.3/6.2.0alpha2) an Url parameter is set in any case, if you toggle the standard/advanced search switch. This parameter should only be set in case of advanced search to prevent duplicate content, speaking url headaches and overloaded urls. Patch tested with bilingual content.

In SearchFormController.php, starting from line 1425:

        if ($this->conf['show.']['advancedSearchLink']) {
//            $linkToOtherMode = $this->piVars['ext'] ? $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 0)) : $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 1));
            $linkToOtherMode = $this->piVars['ext'] ? $this->pi_getPageLink($GLOBALS['TSFE']->id) : $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 1));
            $markerArray['###LINKTOOTHERMODE###'] = '<a href="' . htmlspecialchars($linkToOtherMode) . '">' . $this->pi_getLL(($this->piVars['ext'] ? 'link_regularSearch' : 'link_advancedSearch'), '', 1) . '</a>';
        } else {
            $markerArray['###LINKTOOTHERMODE###'] = '';
        }

p.s. sorry for not providing a patch file - don't know how to do it.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #61982: Regression fix for wrong backport of indexed_search patch #51189ClosedMarkus Klein2014-09-30

Actions
Related to TYPO3 Core - Bug #78316: Regression: Wrong link to normal search mode if advanced mode is active by defaultClosed2016-10-17

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25314

Actions #2

Updated by Tomita Militaru over 10 years ago

Thanks for the patch.

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25314

Actions #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31419

Actions #5

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31420

Actions #6

Updated by Tomita Militaru almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Garvin Hicking almost 10 years ago

Hi!

It seems that the bugfix resolving #51189 was not properly merged in TYPO3 6.1 and 6.2 trees.

For reference, 6.1 uses this:

https://git.typo3.org/?p=Packages/TYPO3.CMS.git;a=commit;h=900b11bb3ff2ca8697fab8420b794a3054b6b949

and 6.2 uses this:

https://git.typo3.org/?p=Packages/TYPO3.CMS.git;a=commit;h=93a54c8d904f9b4f9941834faa46dccc4705c011

The proper patch is the one from 6.2 (which puts the [ext]=1 link at the last parameter), while in 6.1 the patch uses [ext]=0 at the wrong place.

It seems that 6.1 already contained the proper patch, and that the reverse patch had been applied, reverting the previous fix.

We have locally patched the 6.1 file with the patch of 6.2, and it works there.

Best regards,
Garvin & Jörg

Actions #8

Updated by Markus Klein over 9 years ago

  • Is Regression set to No

Thanks for the report. Unfortunately I stumbled over this just now, which is 2 months too late.
Please always open a new ticket for such regressions.
Did so now: #61982
Will be solved there.

Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions #10

Updated by Benni Mack over 4 years ago

  • Related to Bug #78316: Regression: Wrong link to normal search mode if advanced mode is active by default added
Actions

Also available in: Atom PDF