Project

General

Profile

Actions

Bug #51189

closed

Remove non-needed Url parameter for standard search

Added by Thomas Skierlo over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
Start date:
2013-08-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently (6.1.3/6.2.0alpha2) an Url parameter is set in any case, if you toggle the standard/advanced search switch. This parameter should only be set in case of advanced search to prevent duplicate content, speaking url headaches and overloaded urls. Patch tested with bilingual content.

In SearchFormController.php, starting from line 1425:

        if ($this->conf['show.']['advancedSearchLink']) {
//            $linkToOtherMode = $this->piVars['ext'] ? $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 0)) : $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 1));
            $linkToOtherMode = $this->piVars['ext'] ? $this->pi_getPageLink($GLOBALS['TSFE']->id) : $this->pi_getPageLink($GLOBALS['TSFE']->id, $GLOBALS['TSFE']->sPre, array($this->prefixId . '[ext]' => 1));
            $markerArray['###LINKTOOTHERMODE###'] = '<a href="' . htmlspecialchars($linkToOtherMode) . '">' . $this->pi_getLL(($this->piVars['ext'] ? 'link_regularSearch' : 'link_advancedSearch'), '', 1) . '</a>';
        } else {
            $markerArray['###LINKTOOTHERMODE###'] = '';
        }

p.s. sorry for not providing a patch file - don't know how to do it.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #61982: Regression fix for wrong backport of indexed_search patch #51189ClosedMarkus Klein2014-09-30

Actions
Related to TYPO3 Core - Bug #78316: Regression: Wrong link to normal search mode if advanced mode is active by defaultClosed2016-10-17

Actions
Actions

Also available in: Atom PDF