Task #51512
closed
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54267: As an Editor I want to use a FAL withouth bugs
Unreadable directories cause exceptions
100%
Description
If there is an unreadable file in the fileadmin directory the tree and listing frame of fileadmin throw execptions which make the fileadmin unusable.
reproducing the error:
mkdir -p fileadmin/testDirectory/someDirectory chown root:root fileadmin/testDirectory/someDirectory chmod 600 fileadmin/testDirectory/someDirectory
Browse to "testDirectory" and the issues begin ...
Normally all directoreis in "fileadmin" should be readable but in the case of a network mounted directory (Windows share, SMB/CIFS, NFS, cloud storage, etc.) it could be that parts of the fileadmin directory are unreadable and that this can not get changed by the webadmin.
I am working on a patch.
Files
Updated by Philipp Gampe over 11 years ago
- Category changed from Backend User Interface to File Abstraction Layer (FAL)
- Status changed from New to Accepted
- Assignee set to Bernhard Kraft
- Complexity set to medium
Updated by Bernhard Kraft over 11 years ago
- File patch_51512.diff patch_51512.diff added
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23460
Updated by Bernhard Kraft over 11 years ago
- Status changed from Under Review to Accepted
Updated by Bernhard Kraft over 11 years ago
The question is:
Should the drivers of a FAL storage throw execptions in the case of an error and those exceptions should get handled by the Repository/Storage.
Or should a driver never throw an exception but catch them on the public methods available to the Storage and simply return NULL value results or empty arrays in such a case.
Updated by Andreas Wolf over 11 years ago
- Is Regression set to No
Catching exceptions is the responsibility of the UI/control logic, because it knows best how to deal with them - display a message, discard them or just let the whole operation fail. Driver exceptions could be wrapped by the Storage, to have unified exceptions, but that's not strictly necessary if we limit the types of exceptions that drivers might throw for certain operations.
Updated by Steffen Ritter about 11 years ago
- Assignee changed from Bernhard Kraft to Steffen Ritter
Updated by Gerrit Code Review about 11 years ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905
Updated by Gerrit Code Review about 11 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905
Updated by Steffen Ritter about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 50 to 100
Applied in changeset 017242ff31178adb38812179637923ce94518043.
Updated by Georg Ringer about 10 years ago
works now, can't reproduce in master.
Updated by Riccardo De Contardi over 7 years ago
- Status changed from Resolved to Closed